From owner-cvs-all Mon Apr 8 0:24:47 2002 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 3CA1837B417; Mon, 8 Apr 2002 00:24:42 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id RAA17902; Mon, 8 Apr 2002 17:24:34 +1000 Date: Mon, 8 Apr 2002 17:24:37 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sbin/newfs mkfs.c newfs.c newfs.h In-Reply-To: <54697.1018246653@critter.freebsd.dk> Message-ID: <20020408171638.W6064-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 8 Apr 2002, Poul-Henning Kamp wrote: > In message <20020408154911.F5774-100000@gamplex.bde.org>, Bruce Evans writes: > >On Sun, 7 Apr 2002, Poul-Henning Kamp wrote: > > > >> phk 2002/04/07 07:57:57 PDT > >> > >> Modified files: > >> sbin/newfs mkfs.c newfs.c newfs.h > >> Log: > >> bbsize and sbsize cannot ever be trusted from the disklabel, in > >> particular as there may not be one. Remove #if 0'ed code which might > >> mislead people to think otherwise. > > > >I use this code unconditionally. bbsize and sbsize from the disklabel > >can be trusted in all cases that I know of (if there is a disklabel). > > > >Please back this out. > > I don't intend to. newfs will have to learn the new (not yet > committed) API just like any other program. I will back it out then :-). It is needed at least as a reminder that new API's should support these capabilities. newfs can determine its own super block well enough, but it currently optimizes for time and wastes a sector or two. Similarly for internal data in other filesystems. Filesystems can't determine how much space they should leave for boot blocks. Lots of time has been wasted squeezing boot code into the too-small amount of space that may have been large many years ago. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message