From owner-freebsd-bugs@freebsd.org Sun Sep 6 17:04:01 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F205D9C5254 for ; Sun, 6 Sep 2015 17:04:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C250091C for ; Sun, 6 Sep 2015 17:04:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t86H418w021835 for ; Sun, 6 Sep 2015 17:04:01 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 202933] unwanted behaviour change when writing to revoked terminals Date: Sun, 06 Sep 2015 17:04:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fbsd.bugzilla@fenyo.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Sep 2015 17:04:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202933 Bug ID: 202933 Summary: unwanted behaviour change when writing to revoked terminals Product: Base System Version: 10.1-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: fbsd.bugzilla@fenyo.net Hi, When a terminal is revoked, writing to it sets errno to: - ENXIO until FreeBSD 10.1 kernel - EIO with FreeBSD 10.2 kernel The following program can be used to see this behaviour change: ------------------------------------------------------------------ #include #include #include #include extern int errno; int main() { int id = open("/dev/console", O_RDWR); revoke("/dev/console"); int ret = write(id, "X", 1); if (ret < 0) printf("errno=%d\n", errno); return 0; } ------------------------------------------------------------------ It returns 6 (ENXIO) on FreeBSD 10.1 and 5 (EIO) on FreeBSD 10.2. I wonder if this new behaviour would not be an unwanted side-effect due to kernel changes. For instance, this leads to bug ID 202932 for the rsyslog8 port, that loops endlessly after /dev/console is revoked since the errno code tested to handle correctly this case is now EIO instead of ENXIO. This could happen to some other tools for the same reason. Sincerely, -- You are receiving this mail because: You are the assignee for the bug.