From owner-p4-projects@FreeBSD.ORG  Wed Jun  9 22:33:57 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D92F01065679; Wed,  9 Jun 2010 22:33:56 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9B772106566C;
	Wed,  9 Jun 2010 22:33:56 +0000 (UTC)
	(envelope-from bfiedler@asu.edu)
Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com
	[209.85.216.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 473AD8FC08;
	Wed,  9 Jun 2010 22:33:55 +0000 (UTC)
Received: by qyk11 with SMTP id 11so89348qyk.13
	for <multiple recipients>; Wed, 09 Jun 2010 15:33:55 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.224.12.201 with SMTP id y9mr1965323qay.235.1276121273601; Wed, 
	09 Jun 2010 15:07:53 -0700 (PDT)
Received: by 10.224.80.212 with HTTP; Wed, 9 Jun 2010 15:07:53 -0700 (PDT)
In-Reply-To: <AANLkTin9N4E0L1rqpEzMR79cF5EuFQowiTSt0pKZARHn@mail.gmail.com>
References: <201006090217.o592H6M7095917@repoman.freebsd.org>
	<AANLkTin9N4E0L1rqpEzMR79cF5EuFQowiTSt0pKZARHn@mail.gmail.com>
Date: Wed, 9 Jun 2010 15:07:53 -0700
Message-ID: <AANLkTilDlp_gKVOu7vMi8UxF52BMN39s2UIsFztkkjTV@mail.gmail.com>
From: Ben Fiedler <bfiedler@asu.edu>
To: Garrett Cooper <gcooper@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: Benjamin Fiedler <bfiedler@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 179341 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jun 2010 22:33:57 -0000

>
> >
> > +DEBUG = -g
> >  PROG=  diff
> >  SRCS=  diff.c diffdir.c diffreg.c
> > -CFLAGS+=       -std=c99 -Wall -pedantic
> > +CFLAGS+=       -std=c99 -Wall -pedantic $(DEBUG)
>
> That's what the DEBUG_FLAG var does?
>

Ah, so it does.  Thanks.

>
>
> >
> > -int     aflag, bflag, dflag, iflag, lflag, Nflag, Pflag, pflag, rflag;
> > +int     aflag, Bflag, bflag, dflag, iflag, lflag, Nflag, Pflag, pflag,
> rflag;
>
> This could make merging patches entertaining if you add or remove a
> variable; it probably would be easier if each variable was per-line.
>
> A decent point. I suppose I can do them all on newlines for now..


>
> >  int     sflag, tflag, Tflag, wflag;
> >  int     format, context, status;
>
> ...
>
> > +                   strcmp(dent1->d_name, dent2->d_name) ;
>
> This is kind of hard to read... can this be split up into if-based
> branch statements?
>

It easily could be split; I was just trying to adhere to the already-present
style.


-Ben