From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Mar  2 19:29:17 2015
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B3359426
 for <freebsd-ports-bugs@FreeBSD.org>; Mon,  2 Mar 2015 19:29:17 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7E1B292E
 for <freebsd-ports-bugs@FreeBSD.org>; Mon,  2 Mar 2015 19:29:17 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t22JTHEn096825
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 2 Mar 2015 19:29:17 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 198190] Fix security/p5-CryptX build with clang 3.6.0
Date: Mon, 02 Mar 2015 19:29:17 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports & Packages
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: dim@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: vanilla@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: maintainer-feedback?
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 flagtypes.name attachments.created
Message-ID: <bug-198190-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Mar 2015 19:29:17 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198190

            Bug ID: 198190
           Summary: Fix security/p5-CryptX build with clang 3.6.0
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: vanilla@FreeBSD.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(vanilla@FreeBSD.org)
          Assignee: vanilla@FreeBSD.org

Created attachment 153677
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153677&action=edit
Change inline const rotate functions to macros

During the exp-run in bug 197395, it was found that security/p5-CryptX gives
errors with clang 3.6.0:

http://package18.nyi.freebsd.org/data/headamd64PR197395-default/2015-02-27_12h37m16s/logs/errors/p5-CryptX-0.021_1.log

These errors all because the embedded copy of libtomcrypt uses the 'I' and 'J'
asm constraints incorrectly.  These can only be used with compile-time integer
constants (e.g. numeric literals).

I propose the attached patch, which changes the ROLc/RORc inline function to
macros, so the constraints requirements are satisfied at compile time.  It is
almost exactly the same as the patch for libtomcrypt itself, in bug 198017.

The produced code is exactly the same, as far as I can determine.  I tested
this on i386 and amd64.

-- 
You are receiving this mail because:
You are the assignee for the bug.