From owner-cvs-all@FreeBSD.ORG  Fri Aug 13 22:39:40 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 05A9916A4CE; Fri, 13 Aug 2004 22:39:40 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 88AB343D53; Fri, 13 Aug 2004 22:39:39 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i7DMbvlj096692;
	Fri, 13 Aug 2004 18:37:57 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i7DMbutZ096689;
	Fri, 13 Aug 2004 18:37:57 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Fri, 13 Aug 2004 18:37:56 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Max Laier <max@love2party.net>
In-Reply-To: <200408140032.32139.max@love2party.net>
Message-ID: <Pine.NEB.3.96L.1040813183645.73100V-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net rtsock.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Aug 2004 22:39:40 -0000


On Sat, 14 Aug 2004, Max Laier wrote:

> On Saturday 14 August 2004 00:23, Robert Watson wrote:
> > rwatson     2004-08-13 22:23:21 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/net              rtsock.c
> >   Log:
> >   Use IFQ_SET_MAXLEN() to set the maximum queue depth of the routing
> >   socket netisr queue.
> 
> Well, I suggest to use IFQ_* macros only on queues that are
> IFQ_SET_READY'ed as well. i.e. as long as you don't use IFQ_{EN,DE}QUEUE
> with the queue there is not much point in using IFQ_SET_MAXLEN either.
> It'd just add noise to searches for IFQ_*
> 
> I don't think that there are plans to use ALTQ disciplines on the netisr
> queues, are there? 

No, that wouldn't really make sense, as we want a reliable record stream,
really, and the protocol in question wouldn't benefit from RED, etc.  Do
you suggest, then, just backing this out?  Some of the other ifq
abstractions are used, such as IFF_HANDOFF()...

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Principal Research Scientist, McAfee Research