From owner-freebsd-qa Sun Dec 23 15:25:57 2001 Delivered-To: freebsd-qa@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id C156437B416; Sun, 23 Dec 2001 15:25:52 -0800 (PST) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id fBNNPmD22001; Sun, 23 Dec 2001 18:25:48 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Sun, 23 Dec 2001 18:25:48 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: The Anarcat Cc: re@freebsd.org, qa@freebsd.org, jkh@freebsd.org, phk@freebsd.org Subject: Re: regression tests for possible sysctl kern.disks/libdisk changes/mfc In-Reply-To: <20011223224933.GF34708@shall.anarcat.dyndns.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-qa@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jordan, Can you clarify a couple of things for me? (1) What exactly broke in sysinstall due to not having the names sorted? Was it just a slight visual glitch, or were there fairly material problems? (2) What are the downsides to not merging this feature: do we lose the ability to do something that we might otherwise have? Do things look better? (3) What are the risks? What can possibly go wrong? (sysinstall might multiply list devices, might not list some devices, might offer devices inappropriate to install on, ... I'm cerainly not opposed to this type of change, but if there are observable risks with no real payoff, I'm not sure it's worth those risks. If there's little risk, and lots of payoff, then that is different, of course :-). Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On Sun, 23 Dec 2001, The Anarcat wrote: > Hi. > > A recent commit to -current was done to re-enable the use of sysctl > kern.disks by sorting its output in libdisk. > > This might break sysinstall as it is why the disabling was done in the > first place. > > I have mildly tested sysinstall with the -stable patches, and it seems > to order the disks properly. I haven't tested an install or real-life > partitioning. > > Those wanting to do so need to apply the attached patch and rebuild > libdisk + sysinstall: > > # cd /usr/src/lib/libdisk > # patch < patch > # make clean all install > # cd /usr/src/release/sysinstall > # make clean all install > # /stand/sysinstall > > Since I am not aware of what precisely the original bugs were, I cannot > fully test this. > > Also, I won't be available to test this in the following few days. I > will be back on the 27th and might take my mail sporadically in between. > I will stay for a few days and leave again until the 2nd, so I will be > available for real testing only then. > > Thanks for your attention, > > A. > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-qa" in the body of the message