From owner-cvs-all Mon Sep 23 2: 3:51 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AF6837B401; Mon, 23 Sep 2002 02:03:50 -0700 (PDT) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id E1E8F43E42; Mon, 23 Sep 2002 02:03:49 -0700 (PDT) (envelope-from baka@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1921) id A8097AE1CA; Mon, 23 Sep 2002 02:03:49 -0700 (PDT) Date: Mon, 23 Sep 2002 02:03:49 -0700 From: Jonathan Mini To: Julian Elischer Cc: Ian Dowse , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c linux_sysctl.c src/sys/compat/svr4 svr4_stream.c src/sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c syscalls.master Message-ID: <20020923090349.GK7539@elvis.mu.org> Mail-Followup-To: Julian Elischer , Ian Dowse , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200209230932.aa59018@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG It looks like I'm going to have to revert this patch. Either that, or wrap the code somehow to pass compat structs back to the process. I'll look into it tomorrow. Julian Elischer [julian@elischer.org] wrote : > I've alreay alerted him to some possible problems... > > expect more on this > > On Mon, 23 Sep 2002, Ian Dowse wrote: > > > In message <200209230617.g8N6HswG040488@freefall.freebsd.org>, Jonathan Mini wr > > ites: > > > Log: > > > Don't use compatability syscall wrappers in emulation code. > > > This is needed for the COMPAT_FREEBSD3 option split. > > > > Does this actually work? Presumably the compatibility versions were > > used where they matched the Linux ABI and the native ones didn't? > > exactly... Linux uses BSD4.3 style sockaddr structs > > > > > > Ian > > > -- Jonathan Mini http://www.freebsd.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message