From owner-p4-projects@FreeBSD.ORG  Mon Aug 20 09:11:40 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 48BB416A41B; Mon, 20 Aug 2007 09:11:40 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0699416A418;
	Mon, 20 Aug 2007 09:11:40 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id B4F6313C45A;
	Mon, 20 Aug 2007 09:11:39 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id BB5E98C145B;
	Mon, 20 Aug 2007 11:11:37 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id BYIurTS8Ouas; Mon, 20 Aug 2007 11:11:36 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 7FF728C1387;
	Mon, 20 Aug 2007 11:11:36 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l7K9BaMl047924;
	Mon, 20 Aug 2007 11:11:36 +0200 (CEST) (envelope-from rdivacky)
Date: Mon, 20 Aug 2007 11:11:36 +0200
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Jesper Brix Rosenkilde <jbr@FreeBSD.org>
Message-ID: <20070820091136.GA47764@freebsd.org>
References: <200708200201.l7K21c3v034586@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200708200201.l7K21c3v034586@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 125372 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Aug 2007 09:11:40 -0000

> +	PROC_LOCK(p);
>  	outsysshm.pid = p->p_pid;
> -	strncpy(outsysshm.progtitle, p->p_comm, MAXCOMLEN);
> -	strncpy(outsysshm.proctitle, "\0", 1);
> -	copyout((caddr_t) &outsysshm, (caddr_t) *addr, sizeof(struct sysshm)); 
> +	copyout(&outsysshm, (vm_offset_t *)  p->p_usrsysshm, 
> +			sizeof(struct sysshm));
> +	PROC_UNLOCK(p);

I dont think you can copyout while holding proc lock.