Date: Thu, 11 Jun 2020 05:28:09 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r362041 - stable/12/sys/dev/superio Message-ID: <202006110528.05B5S9lL077616@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: avg Date: Thu Jun 11 05:28:08 2020 New Revision: 362041 URL: https://svnweb.freebsd.org/changeset/base/362041 Log: MFC r361788: superio: do not assume that current LDN cannot change after config exit That assumption should be true when superio(4) uses the hardware exlusively. But it turns out to not hold on some real systems. So, err on the side of correctness rather than performance. Clear current_ldn in sio_conf_exit. Modified: stable/12/sys/dev/superio/superio.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/superio/superio.c ============================================================================== --- stable/12/sys/dev/superio/superio.c Thu Jun 11 05:26:23 2020 (r362040) +++ stable/12/sys/dev/superio/superio.c Thu Jun 11 05:28:08 2020 (r362041) @@ -190,6 +190,7 @@ static void sio_conf_exit(struct siosc *sc) { sc->methods->exit(sc->io_res, sc->io_port); + sc->current_ldn = 0xff; mtx_unlock(&sc->conf_lock); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006110528.05B5S9lL077616>