From owner-svn-src-all@FreeBSD.ORG Tue Jan 4 18:18:28 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17BBA1065675; Tue, 4 Jan 2011 18:18:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id DEF3B8FC13; Tue, 4 Jan 2011 18:18:27 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 84BFF46B09; Tue, 4 Jan 2011 13:18:27 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B6E278A009; Tue, 4 Jan 2011 13:18:26 -0500 (EST) From: John Baldwin To: Julian Elischer Date: Tue, 4 Jan 2011 13:14:08 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201101041316.p04DGSo6037042@svn.freebsd.org> <4D23521C.8020506@freebsd.org> In-Reply-To: <4D23521C.8020506@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201101041314.08949.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 04 Jan 2011 13:18:26 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216954 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2011 18:18:28 -0000 On Tuesday, January 04, 2011 12:00:12 pm Julian Elischer wrote: > On 1/4/11 5:16 AM, John Baldwin wrote: > > Author: jhb > > Date: Tue Jan 4 13:16:28 2011 > > New Revision: 216954 > > URL: http://svn.freebsd.org/changeset/base/216954 > > > > Log: > > kproc_exit() is already marked __dead2 so a NOTREACHED comment here isn't > > needed for lint. > > yes but it IS good documentation when reading the code. Err, no, the point of NOTREACHED is to serve as documentation for lint(1), but that has subsequently been obsoleted by __dead2. Do you put a NOTREACHED comment after every call to exit() in userland? :) -- John Baldwin