From owner-freebsd-rc@FreeBSD.ORG Fri Mar 7 17:58:32 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 233121065673 for ; Fri, 7 Mar 2008 17:58:32 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by mx1.freebsd.org (Postfix) with ESMTP id A0E2D8FC1D for ; Fri, 7 Mar 2008 17:58:31 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so497849fgg.35 for ; Fri, 07 Mar 2008 09:58:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=qKj/aReG1it0H1v0P2Um6OFlXCvdtmPkWZz4F2xeBaU=; b=vp+g9qLkZfkfsRlIoK8NxW9j3Qhoew4NDyy8GVXBv3c6/ffYVK+/iZV2aTEVk6QOyfeekc56ZMgeEHzK6/ZhxN1+p6Sy2FWPuwNVyaapYL25PKXtL6yehPKF+DD+pHoqpHhDrydVmQ460zYeRZBW6Sl/x30UgYJTupbdDt4F+Ok= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=pYyfZ8xPSd4pHBCJJaHpFO8w6GFjdGJU7eSD4kxlG0R/sETI/LrCbdejFGZdcwtGyiYfgsQFuDrmEXzbzNm0vzV6ScnpSVp6fp7ZjMy1V6SWGDOV9uJ7UnrKF62Et0XgzhlIdQ+lY9KgwIO3iJ6RUphmbvSI9AvlgXU/UIEkyzI= Received: by 10.86.70.8 with SMTP id s8mr1776754fga.29.1204911246578; Fri, 07 Mar 2008 09:34:06 -0800 (PST) Received: by 10.86.23.12 with HTTP; Fri, 7 Mar 2008 09:34:06 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2008 09:34:06 -0800 From: "Maksim Yevmenkin" To: "Brooks Davis" In-Reply-To: <20080307154951.GB34313@lor.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803071133.m27BXoXH096841@freefall.freebsd.org> <20080307154951.GB34313@lor.one-eyed-alien.net> Cc: freebsd-rc@freebsd.org, freebsd-bugs@freebsd.org, usselmann.m@icg-online.de Subject: Re: conf/121452: /etc/rc.d/ppp not working as expected X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2008 17:58:32 -0000 On Fri, Mar 7, 2008 at 7:49 AM, Brooks Davis wrote: > The following patch should allow profile name to contain ".-/+" characters > as we do with interfaces. It also documents the previous undocumnted > per-profile overrides of _mode and _nat which were the cause of the problem. > If someone who uses ppp could test this, I'd be happy to commit it. i'm not so sure about this one. if i have "t-dsl" as a profile name, i will not be able to specify any overrides for this profile, because shell won't let me have "ppp_t-dsl_mode" and/or "ppp_t-dsl_nat" variable. so, the translation here is not really needed, imo, and, perhaps, could even be considered harmful. perhaps we should do one of the following 1) demand that ppp profile names should be "shell clean" and document it or 2) if a ppp profile name is not "shell clean" simply do not evaluate profile overrides and use defaults thanks, max