Date: Wed, 1 Jan 2020 10:56:30 -0600 From: Jason Bacon <bacon4000@gmail.com> To: Yuri <yuri@rawbw.com>, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r521506 - head/science/hdf5 Message-ID: <41685c64-27a2-931b-ded6-10e118b935d9@gmail.com> In-Reply-To: <04c9d508-7dd8-5db4-01cb-84259741e11e@gmail.com> References: <201912301657.xBUGvCns014808@repo.freebsd.org> <f34960d7-ab20-303a-103f-8d62a85001c0@rawbw.com> <04c9d508-7dd8-5db4-01cb-84259741e11e@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-01-01 09:30, Jason Bacon wrote: > On 2020-01-01 03:46, Yuri wrote: >> On 2019-12-30 08:57, Sunpoet Po-Chuan Hsieh wrote: >>> Log: >>> =C2=A0=C2=A0 Update to 1.10.6 >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Changes: https://portal.hdfgroup.org/displa= y/support/HDF5+1.10.6 >>> >>> Modified: >>> =C2=A0=C2=A0 head/science/hdf5/Makefile >>> =C2=A0=C2=A0 head/science/hdf5/distinfo >>> =C2=A0=C2=A0 head/science/hdf5/pkg-plist >> >> >> This commit broke science/rmf >> >> >> Yuri >> > Perhaps we could develop a poudriere option to test all dependents as=20 > well as dependencies?=C2=A0 Obviously this would increase testing time = > significantly for some ports, but making thorough testing convenient=20 > for the developer is the main thing. > > An easy way to prevent breakages like this one would be a great=20 > improvement to the ports system.=C2=A0 Even an imperfect solution would= be=20 > a huge help here, I think. > > =C2=A0=C2=A0=C2=A0 JB > Or just script around it.=C2=A0 The hack below should list virtually all = direct dependent ports, though there might be weird edge cases it misses.= #!/bin/sh usage() { =C2=A0=C2=A0=C2=A0 printf "Usage: $0 category/port\n" =C2=A0=C2=A0=C2=A0 exit 1 } if [ $# !=3D 1 ]; then =C2=A0=C2=A0=C2=A0 usage fi : ${PORTSDIR:=3D/usr/ports} cd $PORTSDIR # One category at a time to avoid "argument list too long" # Combine '\' continued *_DEPENDS lines and check for category/port. for category in *; do =C2=A0=C2=A0=C2=A0 if [ $category !=3D Templates ] && [ -e $category/Mak= efile ]; then =C2=A0=C2=A0=C2=A0 for port in $category/*; do =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [ -e $port/Makefile ] && \ =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 awk '{ if (sub(= /\\$/,"")) printf "%s", $0; else print $0 }' \ =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 $port/Makefile*= | grep -q "_DEPENDS.*:$1"; then =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 echo $port =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0 done =C2=A0=C2=A0=C2=A0 fi done hdf5 has some big dependents (e.g. octave) so it would take a while to=20 test them all, but I'm not sure there's any other way to be certain.=C2=A0= =20 Most ports don't have many big dependents, so it wouldn't cost much to=20 test them all.=C2=A0 Also, testing dependents on one OS version and=20 architecture would probably catch almost all the issues. FreeBSD coral.acadix=C2=A0 bacon ~ 790: dependent-ports science/hdf5 audio/csound biology/kallisto cad/freecad cad/gmsh devel/py-tables french/aster french/med graphics/alembic graphics/blender graphics/caffe graphics/gdal graphics/opencv graphics/openimageio graphics/qgis graphics/qgis-ltr graphics/vigra graphics/vips graphics/vv math/ambit math/armadillo math/deal.ii math/dynare math/flann math/labplot math/libmesh math/mathgl math/matio math/moab math/octave math/pdal math/scilab science/ALPSCore science/avogadro2 science/avogadrolibs science/cdo science/cgnslib science/chemps2 science/chrono science/code_saturne science/erkale science/fleur science/gnudatalanguage science/h5utils science/h5z-zfp science/highfive science/InsightToolkit science/jdftx science/kst2 science/lm science/meep science/minc2 science/mpb science/netcdf science/paraview science/py-h5py science/py-netCDF4 science/qmcpack science/rmf science/silo sysutils/slurm-wlm --=20 Earth is a beta site.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?41685c64-27a2-931b-ded6-10e118b935d9>