From owner-svn-ports-all@freebsd.org Wed Jan 1 16:56:35 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB75E1DA64E; Wed, 1 Jan 2020 16:56:35 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-yw1-xc43.google.com (mail-yw1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47ny4L1f4Rz473Y; Wed, 1 Jan 2020 16:56:34 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-yw1-xc43.google.com with SMTP id u139so16304598ywf.13; Wed, 01 Jan 2020 08:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=ol2pKpc0dSROgyDJtrAF0s0xBbEv2xS5qXOOpQU5Ohs=; b=Xxlq7swE/lMkwlrBbS66KuVB8vTjmD6pKxxzGanVR9Zwa6wwBiYqwY/J30zk8SFYS0 bKjHiAAm6aYbvwj+V6uz1uPKnBXl3+Dj7XFcu/q+8rmupGwtYN+hxi9/7tOLFEx9tsoW 9tXEZ98yiaH0a/2Hdqmx6hpXN5APFIlMBGoeyMSR2EExgXIqxynepnRCH7ghg6UFTH3S yAWSdLoiznSziRFdZPsfHq589HAupsbabnjLD0P5u0sOBgwajOTUnuIA+M6TSDZqlqOl ls08M+4AxtsApcOhAd/7Qd1kDNaRyu7IRV15dP6+m+jiMhRn7kqu1wHcFpd8yqJnktwx 7V5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ol2pKpc0dSROgyDJtrAF0s0xBbEv2xS5qXOOpQU5Ohs=; b=KBPSolY3wuUaN4bOBnFrYa1JE5Rm1q053FFCZJnTC39ZJYPGZLTKVgDi0Anitx7hy1 REumS9DoBq4I5hjcpXznyyBafcABAFcAym3pTyPJZv5CMMwbGq92Wk1+5jrsWPDct/U0 cHEla6ZWXWL7x8g/sADukRR3UN3V5LRkkcrbe1TIcJeIp8p3t1jxV1rafI32KRzDc2FI 05Rve1/QQ3mMH27ea3SxyrygZDL7PxSUEH9126yguR1Oo4Gi3OsfQy4c0pdnOYg40HKE dul81hAMtLOQx4Yq5pwG/f8REDVqqcuwGTrg7aEI6JbVKCYf5Zt1iPiTEO1p+guxE6SM xJhw== X-Gm-Message-State: APjAAAXypyMheoAKGzTg98+EPm1q7K1gzGcgTDmEUe7L2VpEdeWkc9S0 LLw2wVEk2Xv6hmWEG2KRp7m0zEy0 X-Google-Smtp-Source: APXvYqxgiPtYX4ftUERTu3qxw8huVKWUEfjDzFI1JRaiyt1cW7OblKMzjOPij0PVIXCjUUpw7L3T4A== X-Received: by 2002:a81:4896:: with SMTP id v144mr62277304ywa.236.1577897792796; Wed, 01 Jan 2020 08:56:32 -0800 (PST) Received: from coral.acadix.biz (2603-6000-a446-9100-0223-24ff-fe37-c4d7.res6.spectrum.com. [2603:6000:a446:9100:223:24ff:fe37:c4d7]) by smtp.gmail.com with ESMTPSA id t5sm21667580ywc.3.2020.01.01.08.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jan 2020 08:56:32 -0800 (PST) Subject: Re: svn commit: r521506 - head/science/hdf5 From: Jason Bacon To: Yuri , Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201912301657.xBUGvCns014808@repo.freebsd.org> <04c9d508-7dd8-5db4-01cb-84259741e11e@gmail.com> Message-ID: <41685c64-27a2-931b-ded6-10e118b935d9@gmail.com> Date: Wed, 1 Jan 2020 10:56:30 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <04c9d508-7dd8-5db4-01cb-84259741e11e@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspamd-Queue-Id: 47ny4L1f4Rz473Y X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Xxlq7swE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of bacon4000@gmail.com designates 2607:f8b0:4864:20::c43 as permitted sender) smtp.mailfrom=bacon4000@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (1.94), ipnet: 2607:f8b0::/32(-2.15), asn: 15169(-1.87), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[3.4.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2020 16:56:35 -0000 On 2020-01-01 09:30, Jason Bacon wrote: > On 2020-01-01 03:46, Yuri wrote: >> On 2019-12-30 08:57, Sunpoet Po-Chuan Hsieh wrote: >>> Log: >>> =C2=A0=C2=A0 Update to 1.10.6 >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Changes: https://portal.hdfgroup.org/displa= y/support/HDF5+1.10.6 >>> >>> Modified: >>> =C2=A0=C2=A0 head/science/hdf5/Makefile >>> =C2=A0=C2=A0 head/science/hdf5/distinfo >>> =C2=A0=C2=A0 head/science/hdf5/pkg-plist >> >> >> This commit broke science/rmf >> >> >> Yuri >> > Perhaps we could develop a poudriere option to test all dependents as=20 > well as dependencies?=C2=A0 Obviously this would increase testing time = > significantly for some ports, but making thorough testing convenient=20 > for the developer is the main thing. > > An easy way to prevent breakages like this one would be a great=20 > improvement to the ports system.=C2=A0 Even an imperfect solution would= be=20 > a huge help here, I think. > > =C2=A0=C2=A0=C2=A0 JB > Or just script around it.=C2=A0 The hack below should list virtually all = direct dependent ports, though there might be weird edge cases it misses.= #!/bin/sh usage() { =C2=A0=C2=A0=C2=A0 printf "Usage: $0 category/port\n" =C2=A0=C2=A0=C2=A0 exit 1 } if [ $# !=3D 1 ]; then =C2=A0=C2=A0=C2=A0 usage fi : ${PORTSDIR:=3D/usr/ports} cd $PORTSDIR # One category at a time to avoid "argument list too long" # Combine '\' continued *_DEPENDS lines and check for category/port. for category in *; do =C2=A0=C2=A0=C2=A0 if [ $category !=3D Templates ] && [ -e $category/Mak= efile ]; then =C2=A0=C2=A0=C2=A0 for port in $category/*; do =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if [ -e $port/Makefile ] && \ =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 awk '{ if (sub(= /\\$/,"")) printf "%s", $0; else print $0 }' \ =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 $port/Makefile*= | grep -q "_DEPENDS.*:$1"; then =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 echo $port =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 fi =C2=A0=C2=A0=C2=A0 done =C2=A0=C2=A0=C2=A0 fi done hdf5 has some big dependents (e.g. octave) so it would take a while to=20 test them all, but I'm not sure there's any other way to be certain.=C2=A0= =20 Most ports don't have many big dependents, so it wouldn't cost much to=20 test them all.=C2=A0 Also, testing dependents on one OS version and=20 architecture would probably catch almost all the issues. FreeBSD coral.acadix=C2=A0 bacon ~ 790: dependent-ports science/hdf5 audio/csound biology/kallisto cad/freecad cad/gmsh devel/py-tables french/aster french/med graphics/alembic graphics/blender graphics/caffe graphics/gdal graphics/opencv graphics/openimageio graphics/qgis graphics/qgis-ltr graphics/vigra graphics/vips graphics/vv math/ambit math/armadillo math/deal.ii math/dynare math/flann math/labplot math/libmesh math/mathgl math/matio math/moab math/octave math/pdal math/scilab science/ALPSCore science/avogadro2 science/avogadrolibs science/cdo science/cgnslib science/chemps2 science/chrono science/code_saturne science/erkale science/fleur science/gnudatalanguage science/h5utils science/h5z-zfp science/highfive science/InsightToolkit science/jdftx science/kst2 science/lm science/meep science/minc2 science/mpb science/netcdf science/paraview science/py-h5py science/py-netCDF4 science/qmcpack science/rmf science/silo sysutils/slurm-wlm --=20 Earth is a beta site.