Date: Tue, 2 Mar 2004 19:27:58 +1100 From: Peter Jeremy <PeterJeremy@optushome.com.au> To: Colin Percival <colin.percival@wadham.ox.ac.uk> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale setlocale.c Message-ID: <20040302082758.GF56509@cirb503493.alcatel.com.au> In-Reply-To: <6.0.1.1.1.20040301174718.0396fcc0@imap.sfu.ca> References: <200403011649.i21GncBT007285@repoman.freebsd.org> <6.0.1.1.1.20040301165122.03942a20@imap.sfu.ca> <20040301173329.GB7533@ip.net.ua> <6.0.1.1.1.20040301174718.0396fcc0@imap.sfu.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 01, 2004 at 05:55:21PM +0000, Colin Percival wrote: > We really need to get some access checks put in place to stop things >like this from happening... Presumably these are just accidental events - a committer has missed the entry in MAINTAINERS or a "tree locked" notice. In most cases, they are probably just as embarrassing for the committer as they are annoying for other affected parties. In this case, what is needed is some sort of warning message "You are committing to a locked branch and haven't included an 'Approved by' line. Are you sure you want to continue?" It would seem fairly trivial to turn src/MAINTAINERS into a file that can be parsed by (eg) CVSROOT*/commit_prep.pl and generate a suitable warning. Obviously, this won't stop deliberate transgressions - but the Project already has various procedures to handle those. Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040302082758.GF56509>