From owner-svn-src-head@FreeBSD.ORG Tue Jan 11 13:12:37 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86C091065673; Tue, 11 Jan 2011 13:12:37 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 97F938FC1E; Tue, 11 Jan 2011 13:12:35 +0000 (UTC) Received: by fxm16 with SMTP id 16so19931182fxm.13 for ; Tue, 11 Jan 2011 05:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=D2prUlPbXnGU6f5LJz79QGHgrQcL+lig6rSKZ7qRsBQ=; b=pLvT9xvvBkIwiL51DBnGW3evme+o/rmsEFv09C5MZTTO+ok0AfRoNn1dGoLarvAntP 0jF6EIrI5WdvI0xGBUJXrxcddjH3VU38FNvCY7KCuvhS6WJS2FlQlIjQsccyO0a95rHH U8EKdTNWrpDyxu7cCQ6sEb6jvy3DtXtCMU/pg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=X1T7TtQj1F8a+AXAeYZzuv+gdzjv5MRrIeILOmghAXKzi6/LdnUT5fkQsjfX6sNAWi f2cQtoXtuaAC268BIVwdzL2hb1DDVVJ+ZGO7H8Gw7gVcKeh3OBKa9NzAhz8MWPc2oTp6 5VA1REEcLkAu4/jYep/z8ohAtwm24oLo6jNDM= MIME-Version: 1.0 Received: by 10.223.95.200 with SMTP id e8mr3184652fan.18.1294749923630; Tue, 11 Jan 2011 04:45:23 -0800 (PST) Received: by 10.223.100.6 with HTTP; Tue, 11 Jan 2011 04:45:23 -0800 (PST) In-Reply-To: <201101111142.p0BBgMjc019149@svn.freebsd.org> References: <201101111142.p0BBgMjc019149@svn.freebsd.org> Date: Tue, 11 Jan 2011 13:45:23 +0100 Message-ID: From: Giovanni Trematerra To: "Andrey V. Elsukov" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217262 - head/sys/geom/nop X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2011 13:12:37 -0000 On Tue, Jan 11, 2011 at 12:42 PM, Andrey V. Elsukov wrote: > Author: ae > Date: Tue Jan 11 11:42:22 2011 > New Revision: 217262 > URL: http://svn.freebsd.org/changeset/base/217262 > > Log: > =A0Round GNOP provider's mediasize to its sectorsize. This prevents KASSE= RT > =A0in g_io_request when geom classes doing tasting. > > =A0PR: =A0 =A0 =A0 =A0 =A0 kern/147852 > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sys/geom/nop/g_nop.c > > Modified: head/sys/geom/nop/g_nop.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/geom/nop/g_nop.c =A0 Tue Jan 11 11:01:29 2011 =A0 =A0 =A0 = =A0(r217261) > +++ head/sys/geom/nop/g_nop.c =A0 Tue Jan 11 11:42:22 2011 =A0 =A0 =A0 = =A0(r217262) > @@ -176,6 +176,8 @@ g_nop_create(struct gctl_req *req, struc > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0gctl_error(req, "Invalid secsize for provi= der %s.", pp->name); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (EINVAL); > =A0 =A0 =A0 =A0} > + =A0 =A0 =A0 if (size % secsize !=3D 0) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 size -=3D size % secsize; It seems to me that the if statement is redundant and you might use parenthesis around "size % secsize" just to have a better readability of the statement IMHO. -- Gianni