From owner-freebsd-toolchain@FreeBSD.ORG  Sun Jan  4 05:02:00 2015
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: freebsd-toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3EE31D64
 for <freebsd-toolchain@freebsd.org>; Sun,  4 Jan 2015 05:02:00 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2128E3217
 for <freebsd-toolchain@freebsd.org>; Sun,  4 Jan 2015 05:02:00 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t0451xwf059886
 for <freebsd-toolchain@freebsd.org>; Sun, 4 Jan 2015 05:01:59 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t0451xJP059885;
 Sun, 4 Jan 2015 05:01:59 GMT (envelope-from root)
Date: Sun, 4 Jan 2015 05:01:59 +0000
To: freebsd-toolchain@freebsd.org
From: "emaste (Ed Maste)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1428: readelf: Handle note types from
 different operating systems
Message-ID: <adbc2fb2bdf8d038d351ea6acb040f01@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1428: readelf: Handle note types from different operating
 systems
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-Cc: <PHID-MLST-i5ptaleg3lqtvx7cknno>
In-Reply-To: <differential-rev-PHID-DREV-lsl5z2duoaqvef2padti-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-lsl5z2duoaqvef2padti-req@FreeBSD.org>
Thread-Index: YTRmNDhhMTEyNjlhZWE2M2RjMWZlZmRhNTYxIFSoyUc=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Jan 2015 05:02:00 -0000

emaste added a comment.

>>! In D1428#3, @rpaulo wrote:
> This looks odd.  Why are we relying on magic numbers instead of constants/enums like before?

Some of the constants in the previous version are Linux-specific, and don't exist in our ELF headers.

We could make up our own constants (e.g. NT_LINUX_AUXV) but it doesn't seem like that would provide much value. The same constant name may have different values on different OSes.

REVISION DETAIL
  https://reviews.freebsd.org/D1428

To: emaste
Cc: rpaulo, freebsd-toolchain