From owner-svn-src-projects@FreeBSD.ORG Fri Aug 13 03:17:03 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A8796106564A; Fri, 13 Aug 2010 03:17:03 +0000 (UTC) (envelope-from jeff@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 982618FC1A; Fri, 13 Aug 2010 03:17:03 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o7D3H3Bt077803; Fri, 13 Aug 2010 03:17:03 GMT (envelope-from jeff@svn.freebsd.org) Received: (from jeff@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o7D3H3uh077801; Fri, 13 Aug 2010 03:17:03 GMT (envelope-from jeff@svn.freebsd.org) Message-Id: <201008130317.o7D3H3uh077801@svn.freebsd.org> From: Jeff Roberson Date: Fri, 13 Aug 2010 03:17:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r211268 - projects/ofed/head/sys/ofed/include/linux X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2010 03:17:03 -0000 Author: jeff Date: Fri Aug 13 03:17:03 2010 New Revision: 211268 URL: http://svn.freebsd.org/changeset/base/211268 Log: - Fix the try_get_module() return value to always be successful. - Add some temporary debugging for module startup order. Sponsored by: Isilon Systems, iX Systems, and Panasas. Modified: projects/ofed/head/sys/ofed/include/linux/module.h Modified: projects/ofed/head/sys/ofed/include/linux/module.h ============================================================================== --- projects/ofed/head/sys/ofed/include/linux/module.h Fri Aug 13 03:16:11 2010 (r211267) +++ projects/ofed/head/sys/ofed/include/linux/module.h Fri Aug 13 03:17:03 2010 (r211268) @@ -44,21 +44,41 @@ #define EXPORT_SYMBOL(name) #define EXPORT_SYMBOL_GPL(name) +#include + +static inline void +_module_run(void *arg) +{ + char name[1024]; + caddr_t pc; + void (*fn)(void); + long offset; + + pc = (caddr_t)arg; + if (linker_search_symbol_name(pc, name, sizeof(name), &offset) != 0) + printf("Running ??? (%p)\n", pc); + else + printf("Running %s (%p)\n", name, pc); + + fn = arg; + fn(); +} + #define module_init(fn) \ - SYSINIT(fn, SI_SUB_RUN_SCHEDULER, SI_ORDER_FIRST, (fn), NULL) + SYSINIT(fn, SI_SUB_RUN_SCHEDULER, SI_ORDER_FIRST, _module_run, (fn)) /* * XXX This is a freebsdism designed to work around not having a module * load order resolver built in. */ #define module_init_order(fn, order) \ - SYSINIT(fn, SI_SUB_RUN_SCHEDULER, (order), (fn), NULL) + SYSINIT(fn, SI_SUB_RUN_SCHEDULER, (order), _module_run, (fn)) #define module_exit(fn) \ - SYSUNINIT(fn, SI_SUB_RUN_SCHEDULER, SI_ORDER_FIRST, (fn), NULL) + SYSUNINIT(fn, SI_SUB_RUN_SCHEDULER, SI_ORDER_FIRST, _module_run, (fn)) #define module_get(module) #define module_put(module) -#define try_module_get(module) 0 +#define try_module_get(module) 1 #endif /* _LINUX_MODULE_H_ */