Date: Thu, 22 Feb 2018 17:52:34 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r462637 - head/devel/py-py Message-ID: <9c54db2e-c667-3e3f-0476-14d6663146ef@FreeBSD.org> In-Reply-To: <201802221951.w1MJpP0u004248@repo.freebsd.org> References: <201802221951.w1MJpP0u004248@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fZy4JqHuve7NqRpOonjlFXlIvrPcBKgfA Content-Type: multipart/mixed; boundary="m8m77NtKZwK1rGp4ueU7oetdaaNCSFZxg"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <9c54db2e-c667-3e3f-0476-14d6663146ef@FreeBSD.org> Subject: Re: svn commit: r462637 - head/devel/py-py References: <201802221951.w1MJpP0u004248@repo.freebsd.org> In-Reply-To: <201802221951.w1MJpP0u004248@repo.freebsd.org> --m8m77NtKZwK1rGp4ueU7oetdaaNCSFZxg Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2/22/2018 11:51 AM, Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Thu Feb 22 19:51:25 2018 > New Revision: 462637 > URL: https://svnweb.freebsd.org/changeset/ports/462637 >=20 > Log: > Remove TEST_DEPENDS to avoid circular dependency > =20 > PR: 220284 > Reported by: danfe >=20 > Modified: > head/devel/py-py/Makefile >=20 > Modified: head/devel/py-py/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/devel/py-py/Makefile Thu Feb 22 19:51:20 2018 (r462636) > +++ head/devel/py-py/Makefile Thu Feb 22 19:51:25 2018 (r462637) > @@ -13,8 +13,6 @@ COMMENT=3D Library with cross-python path, ini-parsin= g,=20 > LICENSE=3D MIT > LICENSE_FILE=3D ${WRKSRC}/LICENSE > =20 > -TEST_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${FLAV= OR} > - > NO_ARCH=3D yes > USES=3D python > USE_PYTHON=3D autoplist distutils >=20 This change is wrong and should be reverted, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220284#c6 It's like trying to run a BUILD_DEPENDS before it is built and installed which is independent of RUN_DEPENDS; You cannot run a TEST_DEPENDS before it is built and installed, which is independent of RUN_DEPENDS. The bug here is Tinderbox. We should not be removing valid dependencies just to appease a broken tool (especially one barely used). Sure Tinderbox "used to" work here, but that's exactly why it should not be used - it is not properly maintained to keep up with framework updates like TEST_DEPENDS. Poudriere has not yet implemented 'make test' because this problem is hard. The naive 'make test' call after 'make stage' is just wrong. One possible solution is to do multiple passes. Build everything, then test everything. Independent "builds". It gets more complicated because "make test" expected to have the port staged, so in my solution you would have to keep a copy of the stagedir for the port until the testing pass and then extract it, install TEST_DEPENDS, and run the tests. --=20 Regards, Bryan Drewery --m8m77NtKZwK1rGp4ueU7oetdaaNCSFZxg-- --fZy4JqHuve7NqRpOonjlFXlIvrPcBKgfA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaj3PiAAoJEDXXcbtuRpfPorAIALMjcPyQoypp0ObdxalWKZsv j7GKcpfFzqDv8IerOWq7iHy0asbVyX+gb2oh+tWr5a4Iz/nGMXsbWrBGk5t1lGwq GJUCllu0eQOn/tUgYw2O/KiNlAFeeyq0y7LjrFb95BUqC6NrJB4L5PRFQxaxMHod VV9Skniu3yeTgBy5fA9IGm89FcgrU4Q+pqsbz11xpzvGw3j2OR/RSZkup7iQvR8P 6ihtotDrYnjZw2G5eeJn5zNjY/z1TZPa7gF9Y1Ra5pAd3VYOjvVCz7EkcvqpEg+7 uiz2lZ/8qRGwva5foFNFdyK5vHBwDz53wHC9mcwOEs0IMWr7nxeRrIhC11nSuVE= =A3Th -----END PGP SIGNATURE----- --fZy4JqHuve7NqRpOonjlFXlIvrPcBKgfA--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9c54db2e-c667-3e3f-0476-14d6663146ef>