From nobody Fri May 2 10:46:19 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zpnf44bMCz5vWsH; Fri, 02 May 2025 10:46:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zpnf35z3Sz4Nky; Fri, 02 May 2025 10:46:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746182779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RsbllGugveboqJLZIeVJZJrrSAbMXII/FIsbpXcjhls=; b=nzKchlLmowFdChYWBR8GEnk55jkt4usOdfXIv8EZEjQV6kpLgmTVmT674znxzkYQ+DU4AL /ideTyKOAcpifC1hYbmSwS0W3ysuQnbdGwXRXgVhsJAvDU+kzod26pK0mD7ndiiHnMjJ3f vW+2fcYdKtMp51/kPTGpre41Lu30d2O7W08BrYvMRemVhdg2SogzfDPJB3gyr/dG0dIS18 y5o33XwHzIqPQ29rubPSDa/Tt7ws3yk5qFoQRAqCeNbSe1UcjaydTLdOtlYuq43FhPiuVE bm0QicBaaXTmn1du1dKV5kLQwz9IimqCyvcHA7TzK+qcmr23lEBM2OUF3SLOJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746182779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RsbllGugveboqJLZIeVJZJrrSAbMXII/FIsbpXcjhls=; b=xcC8WPEMypRitf0m3GG1fMm/gx+fD+aAo5nANv40XUfeogBRssuIsMNHuzk+P+QOAt80Cy 2nCqi0uRa5N7a4KBFNaXC+IzP1+jvVLL18gBEXdM2EDsL4q4D1oHsWiL5V8PwWjXj5QHKw 4EQumkbjxxmY6ZH/z/rSbavxOSufpvFpWHz0SdMy5qsvd97/euW5H0PHoReEj/yGDHk0a+ 4Z5r8fTa5enc5cPYHf7wQN013873qXz66YreNvNAI7xiitJrRlEdezGgL0U58uOvLPHTN4 6EVxh9MT2Afw5PIW1iikyBM/Fb2CeCDOonVZr6elmp2nR6xDm3JhB/2/mmOvVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746182779; a=rsa-sha256; cv=none; b=YZvFFJFl95PRLNdmmSHgys8BSlakI4lcfXJ/50s+OXcG1dblYfOhGy+Fl4c91hmfsDR1WQ 3bSdAw8ykJeqbjkHLnOBNy6KspjYlRjxRlOqZ5ToIRMgvrD/yB/JBa8M2GDBW5454TArYJ 4IhoqsEnioGxadnl+FqxsF4SWY4r/24fPO3+W8ffijHPLd4HDJpaWb0cgTwuoOQj4ACbN7 MUvKLPW+lLvP6FZZ8ynYgq6sQGtxgZMyWhqsraHIrjJuwBvzTTwCcSf4YwoRcW7xfDO1ZP tOcjJqzEbnYcMaoM6yLQNBtmMk/uhZQGI3pJkyfLve1s2sOGixQ1KPggSMx4mA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zpnf34nT3z18M9; Fri, 02 May 2025 10:46:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 542AkJFK036116; Fri, 2 May 2025 10:46:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 542AkJUD036113; Fri, 2 May 2025 10:46:19 GMT (envelope-from git) Date: Fri, 2 May 2025 10:46:19 GMT Message-Id: <202505021046.542AkJUD036113@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Christos Margiolis Subject: git: 2dd67e4f612e - stable/14 - snd_hda: Drain callout in hdac_detach() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2dd67e4f612e76426b7937025f6fc777d9dae6bc Auto-Submitted: auto-generated The branch stable/14 has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=2dd67e4f612e76426b7937025f6fc777d9dae6bc commit 2dd67e4f612e76426b7937025f6fc777d9dae6bc Author: Christos Margiolis AuthorDate: 2025-05-02 10:38:41 +0000 Commit: Christos Margiolis CommitDate: 2025-05-02 10:44:16 +0000 snd_hda: Drain callout in hdac_detach() Because we do not drain the hdac callout during detach, hot-unloading can result in a panic if the callback fires after we have freed the resources it uses. pcm0: detached pcm1: detached hdaa0: detached hdacc0: detached Kernel page fault with the following non-sleepable locks held: exclusive sleep mutex hdac0 (HDA driver mutex) r = 0 (0xfffffe000212c820) locked @ /mnt/src/sys/dev/sound/pci/hda/hdac.c:400 [...] db_trace_self_wrapper() at db_trace_self_wrapper+0xa5/frame 0xfffffe0046b04490 kdb_backtrace() at kdb_backtrace+0xc6/frame 0xfffffe0046b045f0 vpanic() at vpanic+0x226/frame 0xfffffe0046b04790 panic() at panic+0xb5/frame 0xfffffe0046b04850 trap_fatal() at trap_fatal+0x65b/frame 0xfffffe0046b04950 trap_pfault() at trap_pfault+0x12b/frame 0xfffffe0046b04a70 trap() at trap+0x54c/frame 0xfffffe0046b04c50 calltrap() at calltrap+0x8/frame 0xfffffe0046b04c50 --- trap 0xc, rip = 0xffffffff8412e7ec, rsp = 0xfffffe0046b04d20, rbp = 0xfffffe0046b04d40 --- hdacc_stream_intr() at hdacc_stream_intr+0x3c/frame 0xfffffe0046b04d40 hdac_intr_handler() at hdac_intr_handler+0x15c/frame 0xfffffe0046b04d90 ithread_loop() at ithread_loop+0x387/frame 0xfffffe0046b04ef0 fork_exit() at fork_exit+0xa3/frame 0xfffffe0046b04f30 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0046b04f30 --- trap 0xc, rip = 0x829cc531a, rsp = 0x82b8b7a88, rbp = 0x82b8b7aa0 --- KDB: enter: panic [ thread pid 12 tid 100211 ] Stopped at kdb_enter+0x34: movq $0,0x1f09af1(%rip) db> Sponsored by: The FreeBSD Foundation MFC after: 1 day Reviewed by: kib, adrian Differential Revision: https://reviews.freebsd.org/D50087 (cherry picked from commit c50c5a47a9d515a7dbf584c10c7f66e56b29b305) --- sys/dev/sound/pci/hda/hdac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/sound/pci/hda/hdac.c b/sys/dev/sound/pci/hda/hdac.c index 904e3b2001c7..9a7958449f91 100644 --- a/sys/dev/sound/pci/hda/hdac.c +++ b/sys/dev/sound/pci/hda/hdac.c @@ -1757,8 +1757,10 @@ hdac_detach(device_t dev) free(devlist, M_TEMP); hdac_lock(sc); + callout_stop(&sc->poll_callout); hdac_reset(sc, false); hdac_unlock(sc); + callout_drain(&sc->poll_callout); taskqueue_drain(taskqueue_thread, &sc->unsolq_task); hdac_irq_free(sc);