From owner-freebsd-stable@FreeBSD.ORG Wed Apr 18 03:02:46 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A56EC106566C for ; Wed, 18 Apr 2012 03:02:46 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mx1.freebsd.org (Postfix) with ESMTP id 25A0A8FC0A for ; Wed, 18 Apr 2012 03:02:45 +0000 (UTC) Received: by wibhq7 with SMTP id hq7so138990wib.13 for ; Tue, 17 Apr 2012 20:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=t1OJyJxnNJqYhDdxpI9rREFAu0kHIRp89lpIQIw+mOc=; b=HGLga65TaZv1SPFZ84ySOhYHXrMPKjm8N/zZL6Y28rIedG5eBCuuE6X+xCJR2N+JZ8 sY26+e/kONYCY0kXll9XX+kj7D1kBs5542LbM9XqrUSUzcSoglRSHocoVOUmkXAloJD7 XNyp9cXOsdnKMWd4FZHra+tI3Prqv/ia6MwMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding:x-gm-message-state; bh=t1OJyJxnNJqYhDdxpI9rREFAu0kHIRp89lpIQIw+mOc=; b=Mkm2zQZ5uUOZsodSGO18X0kp5XTmBnky6RhcjcetwpUddrjAwxsxoujelh3OiM6+kS /pnrrJvhR2ViV9SbesFCz4JxVfZIiS3EvFpVCfHocel7q6+c8wrwf1SKe9WJYdVObKGr Tbho3EaJYm9CCoBwQ1SwsBeu2Y8y8bO/+B5brVMljb037qXQchKJGezcj3fkGLe2BcQu iObZl8wcm27FS9Z7ypj6ZxdHwRbcTCmUMY2Oe8tmLCwveNyMdumkVIUO6TrCdH13/Ku1 XtF7R/13miWvrDJSqvIxvnxwQwarFINda9nwSMPkIZRJa2DqJ24bF7qyODQ52O8mOB/z 1GgA== Received: by 10.180.92.71 with SMTP id ck7mr2016644wib.2.1334718165031; Tue, 17 Apr 2012 20:02:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.63.4 with HTTP; Tue, 17 Apr 2012 20:02:14 -0700 (PDT) In-Reply-To: <20120418012503.GA25161@icarus.home.lan> References: <20120417182242.GA58449@icarus.home.lan> <20120417195115.GA60447@icarus.home.lan> <20120417200252.GA60718@icarus.home.lan> <20120418012503.GA25161@icarus.home.lan> From: Eitan Adler Date: Tue, 17 Apr 2012 23:02:14 -0400 Message-ID: To: Jeremy Chadwick Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQk89jp1pK9BIpea/kVEicec8+A/PV5UBUQKLBSqbCsLJ7RG6eLHckVxU/WLyXl6R2hMKZgs Cc: freebsd-stable@freebsd.org Subject: Re: top not restoring terminal echo/icanon correctly X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2012 03:02:46 -0000 On 17 April 2012 21:25, Jeremy Chadwick wrote: > Thoughts/comments? =C2=A0Should I close my existing PR and open a new one= ? Please submit the fix to bin/161739. If you can please submit two different diffs: the first which fixes the problem, the second with is general cleanup as a separate PR. CC me on the submission. The goal is keep the patch and your analysis together for future reference. --=20 Eitan Adler