From owner-freebsd-current@FreeBSD.ORG  Mon Mar 29 23:06:44 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1106A16A4CE
	for <current@freebsd.org>; Mon, 29 Mar 2004 23:06:44 -0800 (PST)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E9D9A43D39
	for <current@freebsd.org>; Mon, 29 Mar 2004 23:06:43 -0800 (PST)
	(envelope-from rizzo@icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i2U76hgd071379;
	Mon, 29 Mar 2004 23:06:43 -0800 (PST)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i2U76hcJ071378;
	Mon, 29 Mar 2004 23:06:43 -0800 (PST)
	(envelope-from rizzo)
Date: Mon, 29 Mar 2004 23:06:43 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: Marcel Moolenaar <marcel@xcllnt.net>
Message-ID: <20040329230643.B70930@xorpc.icir.org>
References: <20040329163926.A38109@xorpc.icir.org>
	<20040330005013.GA53546@ns1.xcllnt.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20040330005013.GA53546@ns1.xcllnt.net>;
	from marcel@xcllnt.net on Mon, Mar 29, 2004 at 04:50:13PM -0800
cc: current@freebsd.org
Subject: Re: proposed bsdlabel patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2004 07:06:44 -0000

On Mon, Mar 29, 2004 at 04:50:13PM -0800, Marcel Moolenaar wrote:
> On Mon, Mar 29, 2004 at 04:39:26PM -0800, Luigi Rizzo wrote:
> > if there are no strong objections, I'd like to commit
> > the following minor patch to bsdlabel (and associated bsdlabel.8
> > changes) to implement a '-f' option which enables bsdlabel to
> > work on an image file too.
> 
> As Julian mentioned, why not use stat(2) and DTRT without options?
> That also removes the gratuitous requirement that the filename has
> to be an absolute path. See also the implementation of gpt(8)...

sure, will do that, and take care of the style bugs as bruce
suggested (the original patch was voluntarily formatted in
a way to reduce the diffs).

thanks for the feedback
cheers
luigi