From owner-freebsd-ports@FreeBSD.ORG Fri Dec 3 12:07:38 2010 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 803F51065693; Fri, 3 Dec 2010 12:07:38 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from worf.ds9.tecnik93.com (worf.ds9.tecnik93.com [81.196.207.130]) by mx1.freebsd.org (Postfix) with ESMTP id DD4EA8FC08; Fri, 3 Dec 2010 12:07:37 +0000 (UTC) Received: from it.buh.tecnik93.com (unknown [188.27.101.35]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by worf.ds9.tecnik93.com (Postfix) with ESMTPSA id BD68522C546C; Fri, 3 Dec 2010 14:07:36 +0200 (EET) Date: Fri, 3 Dec 2010 14:07:35 +0200 From: Ion-Mihai Tetcu To: "Ganael LAPLANCHE" Message-ID: <20101203140735.21045b58@it.buh.tecnik93.com> In-Reply-To: <20101203073644.M60677@martymac.org> References: <20101130041323.GA17404@lonesome.com> <4CF51A1F.7030803@gmail.com> <20101130191906.GA28560@lonesome.com> <60D0FDFC-83B5-479D-97ED-922A6D31EF87@FreeBSD.org> <20101130211524.M4648@martymac.org> <20101201103810.46a1be7a@it.buh.tecnik93.com> <20101203073644.M60677@martymac.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.1; amd64-portbld-freebsd8.1) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/LI5vb/zNtOWdF+bWn9fZhSr"; protocol="application/pgp-signature" Cc: FreeBSD Ports , Mark Linimon , Ade Lovett Subject: Re: Introducing USE_SRC and ONLY_FOR_*VER (was: CFR: patch to cleanup usage of SRC_BASE in various ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 12:07:38 -0000 --Sig_/LI5vb/zNtOWdF+bWn9fZhSr Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 3 Dec 2010 08:59:22 +0100 (CET) "Ganael LAPLANCHE" wrote: > On Wed, 1 Dec 2010 10:38:10 +0200, Ion-Mihai Tetcu wrote >=20 > Hi, >=20 > > > It would be interesting to provide something like : > > >=20 > > > USE_BASE=3D yes=20 > > > Which would do the following : > > > =3D> defines ${SRC_BASE} > > > =3D> checks for ${SRC_BASE}/sys/Makefile > > > =3D> provides a standard error msg if not found > > >=20 > > > or, if set to something other than yes : > > >=20 > > > USE_BASE=3D some/file/within/src_base > > > =3D> defines ${SRC_BASE} > > > =3D> check for ${SRC_BASE}/some/file/within/src_base > > > =3D> provides a standard error msg if not found > > >=20 > > > Thus, we would avoid having the same tests again and again, and > > > be able to provide more "standard" messages... > > >=20 > > > What do you think ? > >=20 > > Yes. It would help tracking some errors on automated build systems. >=20 > Following this idea, here is a small patch that provides that > functionality : >=20 > http://people.freebsd.org/~martymac/patches/20101203-patch-bsd.kmod.mk.txt Submit a PR with it please. --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/LI5vb/zNtOWdF+bWn9fZhSr Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAkz43YgACgkQJ7GIuiH/oeX36gCdELbtZfe0y/U8hhIBo/LQqWok v8AAoIyWPjxape0guG4NJ4WDwpvLXgqQ =Oy9O -----END PGP SIGNATURE----- --Sig_/LI5vb/zNtOWdF+bWn9fZhSr--