From owner-svn-src-all@freebsd.org Sat Jan 27 22:58:57 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59744EC8A7D for ; Sat, 27 Jan 2018 22:58:57 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic312-36.consmr.mail.ne1.yahoo.com (sonic312-36.consmr.mail.ne1.yahoo.com [66.163.191.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E80707E639 for ; Sat, 27 Jan 2018 22:58:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1517093936; bh=BfEGz7TEtJLG3i+jJCI6ml2izEOfwY/agIzWT7aCHIc=; h=Subject:From:To:References:Date:In-Reply-To:From:Subject; b=Rn2UUxsReAkZMOecG1MS/iW+5ekzzSk2DUw2k065wFJt8dEvL0aS76JErBm5PM9fVANfvak/YyhHDgGaf4MT0jJ9fFV2KuuAxEe8fjQps979uk3m/V8k2bBlOW2lpjXmg4UzBMQHvlBFg82dwYCuWomb79K6ESar4+X1Lo8UlNbiIHTnZpDdchTsYEQ0rgD3NJq6hJa2DPruGKpszqpYEem96tlzoQpFum0BAl30iU3G720SNtmEkkeTrA1Pgzomwxs1nWtuBpZtqVIjhes4UnBdnGtGaW8JuYphZwaa1rhfqSsLFhknpt8vhPivCSWxLRZXnkv+POgTDtaE71U4rw== X-YMail-OSG: yZgq9xUVM1kn55b9JfHAXFC8UmcGvdfKDmRvzvp25718rJ5g.K9E8d9XaHFceuE wQELONWXrIhCyynAQRixN4DRCTWSDacvvF6_94GCB9QZhTy_eEvpe_PFYSDkagd7FiJ3X3S18Lye ygnx_0SacUGwi8CTMcrrN46fw6IRXcPQ_XopcesZ7Hw02LjgSo0pLzLfETSjj86CxsacEQLFowMP fHJkHp2K9jbYCT8SHTyTAyfNSuzuH6CehmQmpyZxKC1u35uQcxhL.yjwjyralWiB5mKPKRnjKVA3 B6UhWNmHwMh4XClHSCJXT8LZgvKLfDmRguVsXbZF1HPrIK4Yt_E19SCVjYqseuLkgdyfFa4xc_nG MhubJ7lc9TTTJJ1YrWtecWoq6JmG1LvrzI9u7CHSyDNG9BAe6odVx85VOdmCtrQ9KpWq.te5evse kFizo0jVIb28ymLu3TN.8VDBRstRmBA8ZulTpSgCS7kAR88PSHjTmK0xEAnsLntAa0sI5lSbrCMX AAl1x3npcIg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 27 Jan 2018 22:58:56 +0000 Received: from smtpgate103.mail.ne1.yahoo.com (EHLO [192.168.0.8]) ([216.155.193.162]) by smtp415.mail.ne1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID d3d43b418667210d2593a20331613847; Sat, 27 Jan 2018 22:58:51 +0000 (UTC) Subject: Re: svn commit: r328493 - head/lib/libthr/thread From: Pedro Giffuni To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201801272227.w0RMRtmk062757@repo.freebsd.org> Message-ID: <7fe99389-750d-78f5-fd55-2c63bf814019@FreeBSD.org> Date: Sat, 27 Jan 2018 17:58:51 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <201801272227.w0RMRtmk062757@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 22:58:57 -0000 For the record ... On 01/27/18 17:27, Pedro F. Giffuni wrote: > Author: pfg > Date: Sat Jan 27 22:27:55 2018 > New Revision: 328493 > URL: https://svnweb.freebsd.org/changeset/base/328493 > > Log: > libthr: Fix missing break in switch. > Hmm.. There is no "missing break" I just copy/pasted the Coverity report (a false positive). Sorry if that confused people. Pedro. > This is also a warning in recent GCC with -Wimplicit-fallthrough. > > CID: 1356262 > Obtained from: DragonFly (git 0f037c78 - partial) > > Modified: > head/lib/libthr/thread/thr_printf.c > > Modified: head/lib/libthr/thread/thr_printf.c > ============================================================================== > --- head/lib/libthr/thread/thr_printf.c Sat Jan 27 22:16:19 2018 (r328492) > +++ head/lib/libthr/thread/thr_printf.c Sat Jan 27 22:27:55 2018 (r328493) > @@ -95,6 +95,7 @@ next: c = *fmt++; > case 'p': > pstr(fd, "0x"); > islong = 1; > + /* FALLTHROUGH */ > case 'd': > case 'u': > case 'x': >