From owner-svn-ports-all@FreeBSD.ORG Mon Nov 26 16:58:10 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2854832F for ; Mon, 26 Nov 2012 16:58:10 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 763038FC18 for ; Mon, 26 Nov 2012 16:58:09 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so10881013lah.13 for ; Mon, 26 Nov 2012 08:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=uroKBZZjMDsgVYmS2q8X2RvMGRJjRoa5SMu5rOP0IPY=; b=CGbikPbCVviySusziRv8uk0OrP9PdREF3mXvo6wQ16JAuK4oqvud+1TxA5lGLp2N/4 sOcuDEgftIJn76LwERvOfmt9DtQRp/37QVg+qlY6+wZuTV1kHGTZm09UY3yfjQjwnU/z TWmbIGQVvm1PeE6f2h5igEg46koO0CWIUclPU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=uroKBZZjMDsgVYmS2q8X2RvMGRJjRoa5SMu5rOP0IPY=; b=gVp3tVhsCBCVXklf+MacL7NMhIJ8JNuL4O9ndQA7rZBpjicNoiz5cpdCWAI3Dijlf6 FCPFIGlZnbHnMIWbOpaLDQXP87Gn3cTOe8uZbi0A7NGN0UIsFHcO4KWbMFq3gamZQ2RP kv8IwbPZT6kUgkRw43qeQaMvUrnDnWoYoxBjwjfl1e+PpqnQeWm7hYGbjiZ0s/JnOoBO ANJ2jzYsLlvFsgeKYgquRIId0CNqUbdGjDVlvBt/jmIiSWBqfwYfg8Pf6sjamcF4iUtl Gu/gPCHXVP719KXoA/6TsyIOeeuqIUb86yAEi+oV/ku0CEKIQAxQL5SWrLhVHfevbnry veow== Received: by 10.152.105.33 with SMTP id gj1mr11707655lab.49.1353949088145; Mon, 26 Nov 2012 08:58:08 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.154.168 with HTTP; Mon, 26 Nov 2012 08:57:37 -0800 (PST) In-Reply-To: <20121126161113.GA72036@FreeBSD.org> References: <201211261259.qAQCxdXD089022@svn.freebsd.org> <20121126135609.GC62928@FreeBSD.org> <50B39163.2040309@FreeBSD.org> <20121126161113.GA72036@FreeBSD.org> From: Eitan Adler Date: Mon, 26 Nov 2012 11:57:37 -0500 X-Google-Sender-Auth: lDOMfXyVFpljaxfR0vaX1u8E7mU Message-ID: Subject: Re: svn commit: r307782 - head/audio/asunder To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnYg96FQFYNmVChxb2xZnCibGrwXnlRUakZvRAsfg+AulyyE9QiDvc2tYQKz/bYdS5q22jP Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Guido Falsi , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2012 16:58:10 -0000 On 26 November 2012 11:11, Alexey Dokuchaev wrote: > On Mon, Nov 26, 2012 at 04:57:23PM +0100, Guido Falsi wrote: >> On 11/26/12 14:56, Alexey Dokuchaev wrote: >> >We have standard knob for this one (APE_DESC). >> > >> >> PORTDOCS= AUTHORS COPYING ChangeLog INSTALL NEWS README TODO >> > >> >Normally we do not install COPYING as part of the docs, LICENSE should be >> >set instead. If software expects to find this file (e.g. for displaying in >> >the about dialog), it should be redirected to share/licenses/${PKGNAME} >> >instead (see `graphics/luminance' port for an example). >> >> Thanks for these, I'll fix them and commit after maintainer approval. > > Technically speaking, you don't have to have maintainer's approval for these > things, as they don't affect functionality, just make the port more adhering > to our standards (and common sense). It is good to ping the maintainer though unless there is specific reason not to. - Since they signed up to maintain the port its nice not to change things without asking - It teaches the maintainers about our standards :) -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams