From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 17 00:40:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A34BA1065673 for ; Sat, 17 Mar 2012 00:40:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 7AB9D8FC14 for ; Sat, 17 Mar 2012 00:40:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2H0eA54076531 for ; Sat, 17 Mar 2012 00:40:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2H0eADm076530; Sat, 17 Mar 2012 00:40:10 GMT (envelope-from gnats) Resent-Date: Sat, 17 Mar 2012 00:40:10 GMT Resent-Message-Id: <201203170040.q2H0eADm076530@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kevin Oberman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D6D8106564A for ; Sat, 17 Mar 2012 00:30:24 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id E99C68FC0C for ; Sat, 17 Mar 2012 00:30:23 +0000 (UTC) Received: by iahk25 with SMTP id k25so8301926iah.13 for ; Fri, 16 Mar 2012 17:30:23 -0700 (PDT) Received: by 10.182.17.100 with SMTP id n4mr4703355obd.45.1331944223465; Fri, 16 Mar 2012 17:30:23 -0700 (PDT) Received: from rogue.comcast.net (pool-71-102-58-152.plspca.fios.verizon.net. [71.102.58.152]) by mx.google.com with ESMTPS id n7sm4919623oeh.4.2012.03.16.17.30.21 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 16 Mar 2012 17:30:22 -0700 (PDT) Received: by rogue.comcast.net (Postfix, from userid 9381) id 16F4628435; Fri, 16 Mar 2012 17:30:20 -0700 (PDT) Message-Id: <20120317003020.16F4628435@rogue.comcast.net> Date: Fri, 16 Mar 2012 17:30:20 -0700 (PDT) From: Kevin Oberman Sender: Kevin Oberman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/166192: vinagre will not connect to system running TightVNC V2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Kevin Oberman List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Mar 2012 00:40:10 -0000 >Number: 166192 >Category: ports >Synopsis: vinagre will not connect to system running TightVNC V2 >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 17 00:40:10 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Kevin Oberman >Release: FreeBSD 9.0-STABLE amd64 >Organization: >Environment: System: FreeBSD rogue.local 9.0-STABLE FreeBSD 9.0-STABLE #1: Thu Mar 1 19:55:43 PST 2012 root@rogue.local:/usr/obj/usr/src/sys/T520 amd64 >Description: When vinagre attempts to connect to a system running TightVNC V2, the connection is immediately closed due to an off-by-one error in src/gvnc.c. This results in sening back the version string without hte terminating newline. It appears that V1 didn'tmind, but V2 declres this a format error. This problem was reported in the Ubuntu forum at: https://bugs.launchpad.net/ubuntu/+source/gtk-vnc/+bug/598597 >How-To-Repeat: Attempt to connect to any TightVNC V2 server with vinagre or any tool using gtk-vnc. >Fix: NOTE: This path is already in the upstream git repo and should appear in the next release. --- src/gvnc.c +++ src/gvnc.c @@ -3543,7 +3543,7 @@ gboolean gvnc_initialize(struct gvnc *gv gvnc->minor = 8; } - snprintf(version, 12, "RFB %03d.%03d\n", gvnc->major, gvnc->minor); + snprintf(version, 13, "RFB %03d.%03d\n", gvnc->major, gvnc->minor); gvnc_write(gvnc, version, 12); gvnc_flush(gvnc); GVNC_DEBUG("Using version: %d.%d", gvnc->major, gvnc->minor); >Release-Note: >Audit-Trail: >Unformatted: