From owner-freebsd-hackers@FreeBSD.ORG  Sat Feb 12 00:52:50 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19B1C106564A;
	Sat, 12 Feb 2011 00:52:50 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id EB14F8FC08;
	Sat, 12 Feb 2011 00:52:49 +0000 (UTC)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id 792F746B06;
	Fri, 11 Feb 2011 19:52:49 -0500 (EST)
Date: Sat, 12 Feb 2011 00:52:48 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Alexander Leidinger <Alexander@Leidinger.net>
In-Reply-To: <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net>
Message-ID: <alpine.BSF.2.00.1102120051320.49899@fledge.watson.org>
References: <20110211103028.12684f54yrw8tgqo@webmail.leidinger.net>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: hackers@freebsd.org, kibab@freebsd.org
Subject: Re: CFR: FEATURE macros for
 AUDIT/CAM/IPC/KTR/MAC/NFS/NTP/PMC/SYSV/...
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Feb 2011 00:52:50 -0000


On Fri, 11 Feb 2011, Alexander Leidinger wrote:

> during the last GSoC various FEATURE macros where added to the system. 
> Before committing them, I would like to get some review (like if macro is in 
> the correct file, and for those FEATURES where the description was not taken 
> from NOTES if the description is OK).
>
> If nobody complains, I would like to commit this in 1-2 weeks. If you need 
> more time to review, just tell me.
>
> Here is the list of affected files (for those impatient ones which do not 
> want to look at the attached patch before noticing that they are not 
> interested to look at it):

The additions for security/audit and security/mac both seem reasonable; I've 
been meaning to add them myself for quite a bit.  There's then some code in 
libc that can learn to use this as well, at least for MAC.

The one comment I'd make is that the MAC case should indicate that "The MAC 
Framework" is supported, rather than mandatory access controls being present 
-- the presence of the framework doesn't imply the presence of mandatory 
access control policies.

Robert