From nobody Mon Apr 17 05:25:36 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0FrJ73JCz45MFl; Mon, 17 Apr 2023 05:25:36 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0FrJ6Bthz4L5C; Mon, 17 Apr 2023 05:25:36 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681709136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KjnyNeX28c9m/sGLP7YisU6z+TzYhva/CmkgyfyQOYA=; b=MErdF0m7Ev2rWkKz7B9uvxY/Ru/r9dnp9nFVRjQo0AoBCYpDYQuKF7ULepZ/t/TTR4SwI9 mfhuOui0kKKS3RFLekUZak3iRfSyPnaiHzmOSkatc/hkRyldqovHVoQmfPEkrqdysytpcw amK/n9JpdlfQbiaqsJqUVeRxCZqMPhsX8R1wxzxN4DwTK62T8FMGeUThOxDzYfPJCNCVJS jD9yuOI00/c3Zis7xlpGkgMRrM5ktAbby1PhRzp1dAVnioNSuo+HUt2od0fTWY2UOp6PXn gEXUbrkm4M7LJ2faWaf7KNO6JRqgVX+VebyYLlC092u6Krix8mr2FhcODVkPDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681709136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KjnyNeX28c9m/sGLP7YisU6z+TzYhva/CmkgyfyQOYA=; b=iLbS6DCR/tiXvN4X+PqR3DQYGJD7132+dQiG8P8Az4RkHJ7emHHEFIyfKUoBtdMEy/EH/2 t4EMilt6MfXCx1Wa7J8AsT7MlAnoxhEXtduYai8SwVkACwgM43fi7Ps9a5Nihxx3tZPNF+ ya33UqPd398gToC5ljuTpsao/Ez6TP/ruS31VYSnNPqlxaiW7ca4GAMfWttZW5P+DTRiF1 op/6NX7077ZeLCrmsvbBO0iIZoJ+LpFLsDBSlMZLgy9KAd6vSuvXdsuWieo8jh8lFB1q9R zad/s4eK6KUfo/6i8ucPEQwcuowkAJf+XY4aJNnM0L+P2RPiBXa0Rhw9I6N2Aw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681709136; a=rsa-sha256; cv=none; b=Tdi4v/MuNWTbB7sRWMNcOdesmHhw0BIYJwnwvRIgBeNUI8yYkFcfMcpb+i7MNljhDY7/6g tdu7Jx9qbGL1o8JCsC6fsBoYHm9r5zwCg1fH/wDajPKK/3DVQwG5/R9RAm8SZJqGRYT096 JZcM2wd/7UJr93YQMOsfU+S1KZDqR3cq9Q9N0SaHucq//i412hLg/ZEJRT8N/XVWRWSPy9 uEp1LMLfFGuVj5zYua2e4yWnZWMUf7AGH9ox/AjqOFyrhLOHAmF+cAZMnooRN41WbmO8Kb CmycAi5wlufyez4Dk6N6dvrSOY7ke0u1Qr9JV2b4n8+kPWNvBbz8DuIfgB5RuA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id CC50B16973; Mon, 17 Apr 2023 05:25:36 +0000 (UTC) Date: Mon, 17 Apr 2023 05:25:36 +0000 From: Alexey Dokuchaev To: "Stephen J. Kiernan" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1c7ac0c23bc1 - main - veriexec: fix use of getopt Message-ID: References: <202304170105.33H150a7020428@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202304170105.33H150a7020428@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Mon, Apr 17, 2023 at 01:05:00AM +0000, Stephen J. Kiernan wrote: > commit 1c7ac0c23bc12cc7cd5776fa28ebe0582e1bccec > > veriexec: fix use of getopt > > getopt(3) returns int type not char. Using char triggers the > -Wtautological-constant-out-of-range-compare warning with clang. Not just that, depending on the usage (e.g. if there is == -1 check), it could be broken on machines where char is unsigned by default. This is one of those things I could never understand: getopt(3) is said to return `int' by the standard and the manpage, but people keep assigning it to `char' (go figure). ./danfe