Date: Mon, 2 Jan 2012 16:40:26 +0000 From: Andrew Hotlab <andrew.hotlab@hotmail.com> To: <peter@pean.org> Cc: ports@freebsd.org Subject: [patch] sysutils/zfs-periodic Message-ID: <DUB112-W26CB17EE8644A8B751D2E1F6910@phx.gbl>
next in thread | raw e-mail | index | archive | help
First of all=2C it's a very nice and useful port: thank you for supporting =
it! :) I think to have found an error in the file "etc/periodic/weekly/000.=
zfs-snapshot". Here is the patch: --- 000.zfs-snapshot.orig 2012-01-02 17:2=
4:53.000000000 +0100 +++ 000.zfs-snapshot 2012-01-02 17:23:48.000000000 +01=
00 @@ -18=2C7 +18=2C7 @@ keep=3D7 fi -case "$daily_zfs_snapshot_enable" in =
+case "$weekly_zfs_snapshot_enable" in [Yy][Ee][Ss]) . /usr/local/bin/zfs-s=
napshot do_snapshots "$pools" $keep 'weekly' If we want to create snapshots=
at dataset level=2C the main scripts always returns an error=2C because it=
doesn't find the pool name to exccute the scrub chek on. The following pat=
ch extract theZFS pool name from the dataset path: --- zfs-snapshot.orig 20=
11-06-17 00:07:15.000000000 +0200 +++ /usr/local/bin/zfs-snapshot 2011-06-2=
0 09:43:39.000000000 +0200 @@ -3=2C9 +3=2C9 @@ # checks to see if there's a=
scrub in progress scrub_in_progress() { - pool=3D$1 + rootpool=3D`echo $po=
ol | sed 's/\([^\/]*\)\/.*/\1/'` - if zpool status $pool | grep "scrub in p=
rogress"> /dev/null=3B then + if zpool status $rootpool | grep "scrub in pr=
ogress"> /dev/null=3B then return 0 else return 1 I'd glad to see this patc=
h committed to the Ports' repository. Sincerely. Andrew =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DUB112-W26CB17EE8644A8B751D2E1F6910>