From owner-svn-ports-all@freebsd.org Sat Sep 16 17:23:42 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B34D8E23572; Sat, 16 Sep 2017 17:23:42 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-yw0-f180.google.com (mail-yw0-f180.google.com [209.85.161.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F7B182138; Sat, 16 Sep 2017 17:23:42 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-yw0-f180.google.com with SMTP id p10so3048057ywh.8; Sat, 16 Sep 2017 10:23:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=b8Z0T3xb4vg0uSKX+IPABlstsuk4myBQmguASsPaLBE=; b=cW13DNQGnNlC7bFWQktcRz+DHP//jaOtyPf3gnKKVjchFtsWYN84628LcTUYJTcQrm vn/m6K4g26io284+DLcEGuDnTMPaSziJP9wqjSKkFkus1GZuq1KGF1Hi6OU9LxCpHspR QGfb6V7XIgJFWIh8DNw7qxoypK4N32ovHuBKnNVvYjsUxucgQehFFCEmwiSn+wnG9YCe XgL6PT1Oz0GlJfUy5EWf8AMirxCRE5/fNOb4OU+CwqL1uQhYKnHF4vkMuYZqwKZMGuTh Em1ZK69oppUADT2BOKKu1qNQ0p+eMNF96REbbe//gsgo8EU8mDvaydcJw2iRTF/mjEpz nDgg== X-Gm-Message-State: AHPjjUiWXA7IvyKo/rXgZ/L136aq6EKZC5wtf8ictfts0vPQlHmxXRjR Y8nZlYS78R6jnPs1MGo= X-Received: by 10.37.24.194 with SMTP id 185mr2726600yby.339.1505582620974; Sat, 16 Sep 2017 10:23:40 -0700 (PDT) Received: from mail-yw0-f182.google.com (mail-yw0-f182.google.com. [209.85.161.182]) by smtp.gmail.com with ESMTPSA id z5sm118254ywf.21.2017.09.16.10.23.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Sep 2017 10:23:40 -0700 (PDT) Received: by mail-yw0-f182.google.com with SMTP id u11so2446409ywh.7; Sat, 16 Sep 2017 10:23:40 -0700 (PDT) X-Google-Smtp-Source: AOwi7QC1y4furEjyWgiUuOPuMd91brVDEnwwOmtz/FzWmxjPE0hR7HWjWr5IcHHJoU7fjMoHdPV/56LD/5eRzgB78bo= X-Received: by 10.129.65.84 with SMTP id f20mr14782887ywk.372.1505582620539; Sat, 16 Sep 2017 10:23:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.79.211 with HTTP; Sat, 16 Sep 2017 10:23:40 -0700 (PDT) In-Reply-To: <8the-y30s-wny@FreeBSD.org> References: <201709142102.v8EL2q5R011625@repo.freebsd.org> <8the-y30s-wny@FreeBSD.org> From: "Tobias C. Berner" Date: Sat, 16 Sep 2017 19:23:40 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r449853 - in head: . astro/libosmpbf/files audio/sayonara/files databases/kdb/files devel devel/cmake devel/cmake-doc devel/cmake-gui devel/cmake-gui/files devel/cmake-modules devel/cma... To: Jan Beich Cc: "Tobias C. Berner" , Adriaan de Groot , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Sep 2017 17:23:42 -0000 Thanks -- sorry for the inconvenience mfg Tobias On 16 September 2017 at 19:19, Jan Beich wrote: > "Tobias C. Berner" writes: > > > On 16 September 2017 at 18:49, Jan Beich wrote: > > > >> Adriaan de Groot writes: > >> > >> > Author: adridg > >> > Date: Thu Sep 14 21:02:51 2017 > >> > New Revision: 449853 > >> > URL: https://svnweb.freebsd.org/changeset/ports/449853 > >> > > >> > Log: > >> > Update CMake to 3.9, merge devel/cmake-modules into devel/cmake > >> [...] > >> > Index: files/patch-system-libpng16 > >> > =================================================================== > >> > --- files/patch-system-libpng16 (revision 449852) > >> > +++ files/patch-system-libpng16 (revision 449853) > >> > @@ -1,8 +1,10 @@ > >> > Make build glue accept libpng 1.6.x and don't hardcode suffix > >> > > >> > ---- CMakeLists.txt.orig 2015-11-19 15:07:48 UTC > >> > +One hunk in src/CMakeLists.txt was added to fix target generation > with > >> ninja. > >> > >> Don't mix unrelated changes into topic patches. This file may go away > once > >> graphics/png switches to 1.7.*. It's similar to a backport from > upstream. > >> > >> What was broken? Without the change the port still builds fine using > >> CMake 3.9 (both -j1 and -j8). Otherwise, that one-line rationale isn't > >> sufficient for a "portmgr blanket". > > > > The issue is not emulators/ppsspp but its slave emulators/ppsspp-qt5 > which > > gets a dependency cycle: > > > > ==> Building for ppsspp-qt5-1.4.2 > > ninja: error: dependency cycle: cmake_object_order_depends_target_Core > -> > > Core_autogen -> CMakeFiles/Core_autogen -> > > /wrkdirs/usr/ports/emulators/ppsspp-qt5/work/ppsspp-1.4.2/ > git-version.cpp > > -> cmake_object_order_depends_target_Core > > Thanks. Simply quoting the error message often works better as a rationale. > I'll split the fix into a separate file myself. >