From owner-freebsd-net@FreeBSD.ORG Tue Jan 28 23:41:38 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A8F6782 for ; Tue, 28 Jan 2014 23:41:38 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5D28916B2 for ; Tue, 28 Jan 2014 23:41:37 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s0SNfbqk082788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Jan 2014 15:41:37 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s0SNfaqM082787; Tue, 28 Jan 2014 15:41:36 -0800 (PST) (envelope-from jmg) Date: Tue, 28 Jan 2014 15:41:36 -0800 From: John-Mark Gurney To: J David Subject: Re: Terrible NFS performance under 9.2-RELEASE? Message-ID: <20140128234136.GJ13704@funkthat.com> Mail-Followup-To: J David , freebsd-net@freebsd.org References: <20140128002826.GU13704@funkthat.com> <1415339672.17282775.1390872779067.JavaMail.root@uoguelph.ca> <20140128021450.GY13704@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Tue, 28 Jan 2014 15:41:37 -0800 (PST) Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jan 2014 23:41:38 -0000 J David wrote this message on Tue, Jan 28, 2014 at 18:28 -0500: > On Mon, Jan 27, 2014 at 9:14 PM, John-Mark Gurney wrote: > > P.S. if someone wants to submit a patch to mbuf.9 to update the docs > > that would be helpful... I'll review and commit... and m_append is > > also undocumented... > > Would that look something like this be a start in that direction? > > http://pastebin.com/UVir1BET It might be better to move most of m_getm's docs under m_getm2, and document that m_getm is just m_getm2 w/ M_PKTHDR flag set. Could you also document that only M_PKTHDR and M_EOR are valid flags for m_getm2? > This is all very new to me, so I apologize if that's completely wrong. Nope, good first start... > m_append does appear to be documented, it's between m_adj and > m_prepend. (At least it is on 9.2, which is the latest tree I have > access to.) You are correct.. the problem is that the MLINK isn't setup in the Makefile, so: $ man m_append No manual entry for m_append I've fixed that, r261254... > It does also look like m_getm is just a macro in mbuf.h that calls > m_getm2 with flags set to M_PKTHDR, not a function as described in the > man page. It was not immediately obvious if that was intentional or > something that should be fixed or if it's intentionally meant to be > treated as a function from an API standpoint. It's common to use a macro when the change isn't complicated, i.e. just adding a flag... Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."