Date: Sun, 22 May 2011 16:16:37 +0300 From: Ion-Mihai Tetcu <itetcu@FreeBSD.org> To: Matthew Pounsett <matt@conundrum.com> Cc: freebsd-ports@freebsd.org, Doug Barton <dougb@freebsd.org> Subject: Re: Optional Patches Message-ID: <20110522161637.51ff8f97@it.buh.tecnik93.com> In-Reply-To: <DB50B03B-38AA-49CA-B428-F736ED855A59@conundrum.com> References: <C9301CD1-D2C0-449A-BD85-8488FDC028B5@conundrum.com> <4DD443DD.90909@infracaninophile.co.uk> <4DD44596.9050401@FreeBSD.org> <4DD44B0D.5000402@infracaninophile.co.uk> <DB50B03B-38AA-49CA-B428-F736ED855A59@conundrum.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/9/LFOiSGE/FXpnSsKl0U9zo Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 18 May 2011 19:01:31 -0400 Matthew Pounsett <matt@conundrum.com> wrote: >=20 > Based on the responses here it sounds like I've been doing nothing > wrong so I played around a bit more. I guess in my testing there > must've been some combination of things I didn't get right... I did a > bunch more testing and eventually I made it work doing exactly what > I've been doing, except for the location of the ifdef. >=20 > It turns out that in order to make this work, the .if define must > appear below where bsd.port.pre.mk is included. If it occurs above > that, I guess the definition of .if doesn't exist yet and so the > block doesn't get run at all. Yes, or you need to use bsd.options.mk. > I don't recall seeing this restriction mentioned in the porters' > handbook, but perhaps I missed it. It is documented in PH "5.11.2.2 Syntax" --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/9/LFOiSGE/FXpnSsKl0U9zo Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk3ZDLUACgkQJ7GIuiH/oeWMWgCgg2AMsqjvxaubTqKRWKcVciVp qqoAnAq2VIMXaWRJ/TIkiY1ymj5OXtdG =8TBn -----END PGP SIGNATURE----- --Sig_/9/LFOiSGE/FXpnSsKl0U9zo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110522161637.51ff8f97>