From owner-freebsd-usb@FreeBSD.ORG Wed Aug 20 21:10:21 2008 Return-Path: Delivered-To: usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E92B1065677; Wed, 20 Aug 2008 21:10:21 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 4F63A8FC14; Wed, 20 Aug 2008 21:10:21 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 1018A1A4D80; Wed, 20 Aug 2008 14:10:21 -0700 (PDT) Date: Wed, 20 Aug 2008 14:10:21 -0700 From: Alfred Perlstein To: Hans Petter Selasky Message-ID: <20080820211021.GB16977@elvis.mu.org> References: <20080819194413.GB16977@elvis.mu.org> <200808201619.22720.naylor.b.david@gmail.com> <200808201749.51953.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200808201749.51953.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i Cc: usb@freebsd.org, David Naylor , current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: HEADSUP new usb code coming in. X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2008 21:10:21 -0000 FYI Hans, I'm not planning on taking that part of your patch, no kernels will by default run usb2 for a few weeks. That's the only part I'm rejecting for the time being. I don't want anyone to be "surprised". -Alfred * Hans Petter Selasky [080820 08:48] wrote: > On Wednesday 20 August 2008, David Naylor wrote: > > On Tuesday 19 August 2008 21:44:13 Alfred Perlstein wrote: > > > After a long period of review and testing I am on the verge of > > > committing Hans Peter's new usb stack to -current. > > > > > > The patchset requires a SMALL _493_ line diff to the main code, > > > mostly bug fixes to arm. And then a large number of new files > > > for the usb system. > > > > > > The new usb system will be committed as separate files with > > > the intention of folding them over the old files before the > > > 9.0 release. > > > > > > The diff to the main files is here: > > > http://mu.org/~bright/usb2/usb2_release_001.diff > > > > > > The whole diff, including new files is here: > > > http://mu.org/~bright/usb2/usb4bsd.diff.gz > > > > > > FAQ: > > > Q. Has this been reviewed? > > > A. Yes, pretty strongly by myself and we've consulted with > > > various others, Warner, Scott and Andrew for review/testing. > > > I wouldn't say that Warner or Scott have given full review > > > but just about all questions have been answered. > > > > > > Q. Can we change the name from "usb2_" to my favorite name? > > > A. No. This is for a short period, stop being so annoying. > > > > > > Q. What about the old usb code? > > > A. What about it? :D > > > > > > Q. What about ttys? > > > A. I don't know, we'll address the mpsafe aspects of ttys shortly, > > > Hans is very responsive to SMP issues. > > > > > > Q. Shouldn't you wait? > > > A. Wait for what? No. > > > > > > Q. I have some whitespace nits, can you do those? > > > A. No. It's a 100k line diff and a 3meg delta, we tried really hard > > > to get all whitespace right, but you're welcome to point things out after > > > the commit. > > > > > > Thanks! > > > > This sounds great :-) > > > > I see that in the patch usb2 is not enabled in the kernel by default. Is > > there a timeline for it to be enabled and/or could you provide an alternate > > kernel config with usb2 enabled (temporarily)? > > For KB920X boards the USB2 is enabled by default. It is not much you need: > > +device usb2_core > +device usb2_controller # EHCI/OHCI/UHCI/AT91DCI > +device usb2_storage # USB mass storage support > +device usb2_ethernet # USB ethernet support > +device usb2_wlan # USB wireless LAN support > +device usb2_serial # USB serial support > +device usb2_quirk # USB quirks > +device usb2_template # Device Side Mode USB templates > +device usb2_image # USB Scanner support > > > > > Lastly, is there a web-page where one can check up on the progress of the > > integration of the new code (and the removal of the old code) [preferably > > an up-to-date web-page]. > > No, there is no such webpage. > > --HPS -- - Alfred Perlstein