From owner-cvs-all Sun Jan 19 16: 4: 9 2003 Delivered-To: cvs-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 931) id 276DC37B401; Sun, 19 Jan 2003 16:04:08 -0800 (PST) Date: Sun, 19 Jan 2003 16:04:08 -0800 From: Juli Mallett To: Garrett Wollman Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/dumpfs dumpfs.c Message-ID: <20030119160407.A75258@FreeBSD.org> References: <20030119.133145.02779620.imp@bsdimp.com> <20030120103433.Y21079-100000@gamplex.bde.org> <200301192359.h0JNx2VZ002495@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200301192359.h0JNx2VZ002495@khavrinen.lcs.mit.edu>; from wollman@lcs.mit.edu on Sun, Jan 19, 2003 at 06:59:02PM -0500 Organisation: The FreeBSD Project X-Alternate-Addresses: , , , , X-Towel: Yes X-LiveJournal: flata, jmallett X-Negacore: Yes Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * De: Garrett Wollman [ Data: 2003-01-19 ] [ Subjecte: Re: cvs commit: src/sbin/dumpfs dumpfs.c ] > < said: > > > Only C programmers. It also fails in the int is 17-31 bit cases, and on > > systems where longs are 32 bits and int32_t happens to be implemented as > > long. > > Since we're POSIX programmers, we have additional knowledge about the > data types in question (specifically, that int is no narrower than 32 > bits). I dislike using %d for anything which is not written "int" or guaranteed to be written "int" if you replace typedefs with #define's. It cannot be avoided in some cases. This is C after all, and like you mention, on a POSIXoid system. I don't intend to fix the format stuff, I can't, but I just wanted to note that there exist some inexplicit wrt typing formats in that file that I was not intending to fix. I soo enjoy the time recently I've spent with C# ;) -- Juli Mallett AIM: BSDFlata -- IRC: juli on EFnet. OpenDarwin, Mono, FreeBSD Developer. ircd-hybrid Developer, EFnet addict. FreeBSD on MIPS-Anything on FreeBSD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message