From owner-svn-ports-all@FreeBSD.ORG  Mon Feb 25 04:36:07 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 422A8F72;
 Mon, 25 Feb 2013 04:36:07 +0000 (UTC)
 (envelope-from araujobsdport@gmail.com)
Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com
 [209.85.212.175])
 by mx1.freebsd.org (Postfix) with ESMTP id 33515CCC;
 Mon, 25 Feb 2013 04:36:05 +0000 (UTC)
Received: by mail-wi0-f175.google.com with SMTP id l13so2885009wie.14
 for <multiple recipients>; Sun, 24 Feb 2013 20:35:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:reply-to:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=Vl1h87OJlrB0uqBH+1QyDV9ER/LUx5bliH89ktTfWpU=;
 b=busK7mKguiBrDF3YBDOkv/YF6gXGNBow0N4D73k9N5D0buaIf2QE3yIIk1O2soYL1G
 g0BBMH6iwEr7wGtwNPI7oBl72i/w/cTLTMMgpadqWDQHEVLoU1bX4ij28hfEuiZ+4L/b
 xPoOKEUe0JSeG9v4bc+VtL4/2ScfhGygvDuMs1EUL6JS+5MvAHcg0RZCNo6qDyVUy1Gb
 PU8r/rOm9w3zhY1zIU48y4XgFTUaKw2FCpu8b5NY92F7EPp+P04tezYf/xLpFLofN2Gd
 wp2TrbaVl5VtiQD4oPbyai3W80oiY2CrEZkitVlRj9DPNli3do9AmR6bvl4LXAQK2p0f
 bh1g==
MIME-Version: 1.0
X-Received: by 10.180.94.69 with SMTP id da5mr9483323wib.30.1361766959640;
 Sun, 24 Feb 2013 20:35:59 -0800 (PST)
Received: by 10.180.81.4 with HTTP; Sun, 24 Feb 2013 20:35:59 -0800 (PST)
In-Reply-To: <201302250425.r1P4Pc9u020378@svn.freebsd.org>
References: <201302250425.r1P4Pc9u020378@svn.freebsd.org>
Date: Mon, 25 Feb 2013 12:35:59 +0800
Message-ID: <CAOfEmZh3mqERhFPS8eYfgbCsnNtMq5kPiyYQnTHh5=vKnWRv0A@mail.gmail.com>
Subject: Re: svn commit: r312904 - head/net-im/imspector
From: Marcelo Araujo <araujobsdport@gmail.com>
To: Po-Chien Lin <pclin@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: araujo@FreeBSD.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2013 04:36:07 -0000

2013/2/25 Po-Chien Lin <pclin@freebsd.org>

> Author: pclin
> Date: Mon Feb 25 04:25:37 2013
> New Revision: 312904
> URL: http://svnweb.freebsd.org/changeset/ports/312904
>
> Log:
>   - Add IPFW suuport [1] and enable it by default [2]
>   - Trim Makefile header [2]
>   - Remove invalid entry from MASTER_SITES
>   - Patch to fix clang compiling
>   - Tune pkg-plist to pet portlint(1)
>
>   PR:           ports/175765
>   Submitted by: Oleg_Sch <7zsfx@7zsfx.info> [1]
>   Approved by:  Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer) [2]
>   Approved by:  swills (mentor)
>
>
Dear Po-Chien,

For my eyes, it is pretty much strange when we have two lines of "Approved
by" or more then one line of Submitted by or wherever, usually we use only
one line, and something like bellow:

Approve by:    Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer)
                      swills (mentor)

An example to submit:

PR:                   ports/1111 [1], ports/22222 [2], ports/33333 [3]
Submitted by:    Marcelo Araujo (maintainer) [1]
                        Swills [2]
                        Bill Gates [3]


I'm really not sure if we have it documented on P-Handbook, but as far as I
know, we always have it like this.

Best Regards,
-- 
Marcelo Araujo
araujo@FreeBSD.org