From owner-svn-src-head@freebsd.org Mon Feb 5 21:37:42 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5F4CEF2047; Mon, 5 Feb 2018 21:37:42 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 380A28ACAB; Mon, 5 Feb 2018 21:37:42 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io0-x229.google.com with SMTP id f4so243706ioh.8; Mon, 05 Feb 2018 13:37:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QW+yJ5iaBtbwQuCYd8sEa7b73RDcT6d6PyUT2jG74/o=; b=Rxf1ZstoBURdpE2L2BVRtY20ETwG+9rsu/qK4OuAjHAklWZzd73Pv+LvJR1WBO/u20 kvDZM7aMHZ5YofNLY1/9UowkY12ekkuzu8sILXNp9RG6Fbr8gcOv9HY3dPX79B0wVX4O Qg5pviOc7dFnBTFPtCRuekN6otRxlGUWSHg9zLdOxyHlAx5ORk1qew7MUuRGPw3tqtdY ndPNl/RFr9zGSfXdOVRBVNeuNH9g7Rq8R0HHvxNb3o7nGYzqGCLt4okJJqaBGTRPnGf6 ae0uaCdr1SPS2NdwZN0PpDeJd0dM2xLNy+WEiGD7zooELmKpYaBXI4kPp7PLMPpov7gC /N+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QW+yJ5iaBtbwQuCYd8sEa7b73RDcT6d6PyUT2jG74/o=; b=dX/YUiNtBZ1xP8MoZ4foawUWAfQWrny8IcMHAFW6rk2WUinWupIT2pYN0b+IkYMV14 wDUPG+QyYtakTIXdwcwEtzp+mbLFTgGHKLieKyna/l4yvbb3CJwrld/EPua+szv9kovj NVPRWfyP+FqHQaNuoJPwgrMv7JpI0wptufPU7R+cVjtTYrDRqFCooiIFd1uEbe1SYToK 73mv5MCXKQPeaZROXfkqCRj1QQVGIHiq2vAjbzOuHMAwrYEJ0C8dNPJ9GbllZC5IA5/R PHHHIjWl0gC+rF9bGVqmgGBcWNFFVCrDRTzQfqyPOV0hCGOtuHEhkXL9bMjF6kD7gpHT iIVA== X-Gm-Message-State: APf1xPBepzglNxZWzL3zNcVjcGCaloAS7F+9sL2qQEzKEBQgJctWQMyT 5HmPdujXhoqIm9ZPFvZaihJ/NB21yftG4Y4aq/qRUttu X-Google-Smtp-Source: AH8x226PGmXpt1dlLJr6huXP6obTSTcv7HcxJ2kjHWmAh2zboJUjmZWToCI9hVSX3vDgTBy5OmQRCnlt8w1jkoT7oCU= X-Received: by 10.107.173.225 with SMTP id m94mr337674ioo.36.1517866661432; Mon, 05 Feb 2018 13:37:41 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.152.9 with HTTP; Mon, 5 Feb 2018 13:37:20 -0800 (PST) In-Reply-To: <3114578.qyyx4qh6ii@ralph.baldwin.cx> References: <201801302329.w0UNTRHn080138@repo.freebsd.org> <3195814.6PcFLP86qD@ralph.baldwin.cx> <3114578.qyyx4qh6ii@ralph.baldwin.cx> From: Ed Maste Date: Mon, 5 Feb 2018 16:37:20 -0500 X-Google-Sender-Auth: htCGaSOla4NRi3BPQqmLra8JXJ8 Message-ID: Subject: Re: svn commit: r328610 - head/sys/amd64/amd64 To: John Baldwin Cc: Wojciech Macek , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 21:37:42 -0000 On 31 January 2018 at 11:14, John Baldwin wrote: > On Wednesday, January 31, 2018 10:31:36 AM Ed Maste wrote: >> On 30 January 2018 at 21:01, John Baldwin wrote: >> > On Tuesday, January 30, 2018 11:29:27 PM John Baldwin wrote: >> >> Author: jhb >> >> Date: Tue Jan 30 23:29:27 2018 >> >> New Revision: 328610 >> >> URL: https://svnweb.freebsd.org/changeset/base/328610 >> >> >> >> Log: >> >> Ensure 'name' is not NULL before passing to strcmp(). >> >> >> >> This avoids a nested page fault when obtaining a stack trace in DDB if >> >> the address from the first frame does not resolve to a known symbol. >> >> >> >> MFC after: 1 week >> >> Sponsored by: Chelsio Communications >> > >> > This appears to be fallout from lld? After fixing this, the stack trace >> > for my next panic shows no symbols for functions in the kernel, only >> > functions in kernel modules: >> >> It's fallout from loader changes in r328536. I reverted r328536 (and >> r328603) locally and stack traces are fixed. > > Ouch. I'll try to look at this later today unless someone else beats me to > it. I committed a band-aid fix in r328826 but it still needs more investigation / proper fix.