From owner-svn-src-projects@FreeBSD.ORG Fri Sep 2 18:54:22 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B24CC1065672; Fri, 2 Sep 2011 18:54:22 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 5F1C08FC14; Fri, 2 Sep 2011 18:54:22 +0000 (UTC) Received: by qyk9 with SMTP id 9so2164485qyk.13 for ; Fri, 02 Sep 2011 11:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=ILwKGXequqi244No8i/Kex2fXhiAluh/EysTPQ8F7Vg=; b=NpOOjz9ECf7NJ3CAg4ZVB8Orp97rjqIib9aPLP0AASMOajS0g/qAB/R5DQvVWcTiYi H8F0VvP5BYmjNIiHKZTJhpM9VWJ4hgA0mnWdrnSTTFYk8ohqnB+9nnhEYXiffu3Nldor BkWRot+CJYORPJQYzb9/mAl/5CKkqYPUggV+8= MIME-Version: 1.0 Received: by 10.229.66.41 with SMTP id l41mr1050667qci.170.1314989660157; Fri, 02 Sep 2011 11:54:20 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.229.98.8 with HTTP; Fri, 2 Sep 2011 11:54:20 -0700 (PDT) In-Reply-To: <201109021852.p82IqH1M011851@svn.freebsd.org> References: <201109021852.p82IqH1M011851@svn.freebsd.org> Date: Fri, 2 Sep 2011 11:54:20 -0700 X-Google-Sender-Auth: H1BDN-d9U6xwsBSRwt0dCv7RJdk Message-ID: From: mdf@FreeBSD.org To: src-committers@freebsd.org, svn-src-projects@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: svn commit: r225351 - projects/ino64/sys/ufs/ufs X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2011 18:54:22 -0000 Is anyone using UFS_EXTATTR_AUTOSTART? I think the code is now correct for the endpoint of the returned dirent's, but it would be nice to have a review and/or someone test the code. Thanks, matthew On Fri, Sep 2, 2011 at 11:52 AM, Matthew D Fleming wrote: > Author: mdf > Date: Fri Sep =A02 18:52:17 2011 > New Revision: 225351 > URL: http://svn.freebsd.org/changeset/base/225351 > > Log: > =A0ufs: Stop mangling dirent in ufs_extattr_iterate_directory. > =A0It's meaningless after switching to new dirent format. > > =A0GSoC r223159. > =A0Code by: Gleb Kurtsou. > > Modified: > =A0projects/ino64/sys/ufs/ufs/ufs_extattr.c > > Modified: projects/ino64/sys/ufs/ufs/ufs_extattr.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- projects/ino64/sys/ufs/ufs/ufs_extattr.c =A0 =A0Fri Sep =A02 18:50:44= 2011 =A0 =A0 =A0 =A0(r225350) > +++ projects/ino64/sys/ufs/ufs/ufs_extattr.c =A0 =A0Fri Sep =A02 18:52:17= 2011 =A0 =A0 =A0 =A0(r225351) > @@ -397,20 +397,8 @@ ufs_extattr_iterate_directory(struct ufs > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (error); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} > > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* XXXRW: While in UFS, we always get DIR= BLKSIZ returns from > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* the directory code on success, on othe= r file systems this > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* may not be the case. =A0For portabilit= y, we should check the > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* read length on return from ufs_readdir= (). > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*/ > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 edp =3D (struct dirent *)&dirbuf[DIRBLKSIZ]= ; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 edp =3D (struct dirent *)&dirbuf[DIRBLKSIZ = - auio.uio_resid]; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0for (dp =3D (struct dirent *)dirbuf; dp < = edp; ) { > -#if (BYTE_ORDER =3D=3D LITTLE_ENDIAN) > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dp->d_type =3D dp->d_namlen= ; > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dp->d_namlen =3D 0; > -#else > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dp->d_type =3D 0; > -#endif > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (dp->d_reclen =3D=3D 0) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0error =3D ufs_extattr_look= up(dvp, UE_GETDIR_LOCKPARENT, >