From owner-freebsd-arch Sun Jul 22 1:43: 1 2001 Delivered-To: freebsd-arch@freebsd.org Received: from sneakerz.org (sneakerz.org [216.33.66.254]) by hub.freebsd.org (Postfix) with ESMTP id A3F8037B403 for ; Sun, 22 Jul 2001 01:42:59 -0700 (PDT) (envelope-from bright@sneakerz.org) Received: by sneakerz.org (Postfix, from userid 1092) id E91365D01F; Sun, 22 Jul 2001 03:42:33 -0500 (CDT) Date: Sun, 22 Jul 2001 03:42:33 -0500 From: Alfred Perlstein To: Peter Pentchev Cc: arch@FreeBSD.org Subject: Re: kern/29131: Current hungs in sysctl -a while booting + patch Message-ID: <20010722034233.B49508@sneakerz.org> References: <200107220334.f6M3YRe01219@kan.dnsalias.net> <20010722110626.A819@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010722110626.A819@ringworld.oblivion.bg>; from roam@orbitel.bg on Sun, Jul 22, 2001 at 11:06:26AM +0300 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Peter Pentchev [010722 03:02] wrote: > Hi, > > Can anyone envision any side effects from committing the patch > in this PR? Seems like a trivial fix for a typo to me.. Shouldn't "magic" constants be put into the sysctl.h header? > > >Number: 29131 > > >Category: kern > > >Synopsis: Current hungs in sysctl -a while booting + patch > > > > Index: kern_sysctl.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/kern/kern_sysctl.c,v > > retrieving revision 1.110 > > diff -u -u -r1.110 kern_sysctl.c > > --- kern_sysctl.c 2001/06/22 19:54:38 1.110 > > +++ kern_sysctl.c 2001/07/22 03:04:45 > > @@ -113,7 +113,7 @@ > > * 100 to leave space for pre-assigned oid numbers. > > */ > > if (oidp->oid_number == OID_AUTO) { > > - static int newoid = 100; > > + static int newoid = 0x100; > > > > oidp->oid_number = newoid++; > > if (newoid == 0x7fffffff) -- -Alfred Perlstein [alfred@freebsd.org] Ok, who wrote this damn function called '??'? And why do my programs keep crashing in it? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message