From nobody Sat May 23 23:10:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gNHtq6PGwz6f45D for ; Sat, 23 May 2026 23:10:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gNHtq1gfJz3ns8 for ; Sat, 23 May 2026 23:10:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779577843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BWsFrwSJ7FPHyNZO9x09iAFTaEdOBJy3F7aj0TJivv8=; b=wb/LjQDgOlC/CYyNfeAPOi6d+8fxTKGZ9HMANvT/uLzTLHbo5XhX7YB9khB+HKT2AJqlbW ij0uvYHviMkzjtGiNBwCt29rNF0UW73buc8PR8rA+pYdp4gUZktLQ2znlFsKUJRGclUj5B c3BFAlJfzD0VNaTZvR4CyVtIaKePiIV/KofxuMpFci9aXiXx5j6D5g3z9xkR2fzvr+b4RS wn6Q4xJ4ME6UCRcNt2ncT1+73r8ugVWEdevEK1smDZc+3PupDjqK3THFZ4NcTH3IWZrWgu KYwbP6NoghpNbFRjURPY2ZdfBcbKha/0Ee4xBz+NypIqxJ1QGrzjhHc+6wjZPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779577843; a=rsa-sha256; cv=none; b=lUGHxXEhQ2tLyd6PVxoZrn0h5Bo1AAHr7IokpUzYBreNuMvaFxNTGTva6dqzaxnyG6MROh SvzL9ppHLdjYY0dokoOHu7+0yG2a45sxqnZV/WtYUQWKUxc01OeDya9mIFaNyvi2Je+hW1 EAyRaatw43gUj1200u9CmH7z6rXEtvyAH9CJGYQhvMedrY51xoQIXomQfZwV5Yis0V9hlX V6QKuM13gxoPJwQNyRGAM/AM3V7KtEFKdL+DydJwatj32pRmljtxT8Jds4j0km09cok/Ms I4zdDGqJOggcrRlq3UYBM5lHAtOGWnYl4lYa6MDussZUf8dN7zgBgaY4qVg6vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779577843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BWsFrwSJ7FPHyNZO9x09iAFTaEdOBJy3F7aj0TJivv8=; b=KTqlGCgcGYhCsg30VMpID/J/us5lhHWZHBjbEmZkmPBhPGQyP/SaJ9qClUaLm8/UHUrSCM lF7f7pOj7IBCpLHU22FFBehi8PITeLLhq6lFdq1BOKf8zVjTR7YcMQnl9QXAsQLVZnha8Y ocrREh1VRgrsR2cQrgpus0X6V0eHgLkhssQdcdkRmugTTDa/khyQ+YWUbJFSHyJZb0HN3M qD3MzZmxbD5gMBbePfLEzLz0V8PBJhUZGlHM8M+XzmWyuAqs03pp1MjOB1LKMAU5kCeupb TvaoFgDJxb/Dn9P/85waJGMkhK5gqOf1apfF/t6lnvqBEsoxMEmn3ZXucdQFmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gNHtq0kKyzCW1 for ; Sat, 23 May 2026 23:10:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 34292 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 23 May 2026 23:10:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 4d125ed6e7d4 - main - netlink: Avoid potential undefined behaviour List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4d125ed6e7d445d574c11dc35c40ec3013559806 Auto-Submitted: auto-generated Date: Sat, 23 May 2026 23:10:38 +0000 Message-Id: <6a1233ee.34292.4ff5cb12@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=4d125ed6e7d445d574c11dc35c40ec3013559806 commit 4d125ed6e7d445d574c11dc35c40ec3013559806 Author: Ed Maste AuthorDate: 2026-05-22 14:55:49 +0000 Commit: Ed Maste CommitDate: 2026-05-23 20:59:52 +0000 netlink: Avoid potential undefined behaviour Taking the address of an OOB array element is UB, even if not dereferenced. Reviewed by: des, bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57172 --- sys/netlink/netlink_generic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index c2f82eed5656..50c12175e14e 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -93,12 +93,10 @@ static struct genl_group { static inline struct genl_family * genl_family(uint16_t family_id) { - struct genl_family *gf; - - gf = &families[family_id - GENL_MIN_ID]; KASSERT(family_id - GENL_MIN_ID < MAX_FAMILIES && - gf->family_name != NULL, ("family %u does not exist", family_id)); - return (gf); + families[family_id - GENL_MIN_ID].family_name != NULL, + ("family %u does not exist", family_id)); + return (&families[family_id - GENL_MIN_ID]); } static inline uint16_t