From owner-freebsd-ports@FreeBSD.ORG Mon Aug 25 13:01:03 2008 Return-Path: Delivered-To: ports@FreeBSD.org Received: from straylight.ringlet.net (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with SMTP id 1CABF1065677 for ; Mon, 25 Aug 2008 13:01:01 +0000 (UTC) (envelope-from roam@ringlet.net) Received: (qmail 25321 invoked by uid 1000); 25 Aug 2008 13:00:35 -0000 Date: Mon, 25 Aug 2008 16:00:35 +0300 From: Peter Pentchev To: Jeremy Chadwick Message-ID: <20080825130034.GA1070@straylight.m.ringlet.net> References: <48B2996C.1050203@lozenetz.org> <20080825124806.GA78782@eos.sc1.parodius.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <20080825124806.GA78782@eos.sc1.parodius.com> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: ports@FreeBSD.org, Anton - Valqk Subject: Re: pkg_add feature proposal X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2008 13:01:03 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 25, 2008 at 05:48:06AM -0700, Jeremy Chadwick wrote: > On Mon, Aug 25, 2008 at 02:37:16PM +0300, Anton - Valqk wrote: > > Hi everyone, > >=20 > > I've just got an Idea (maybe others had it too?). > >=20 > > When doing pkg_add [-r] wouldn't it be better if pkg_add checks if _all_ > > dependent packages exists and checksums are ok (after downloaded if with > > -r), etc. checks _before_ installing the packages, because if you get > > 3-4 packages broken/missing when one package depends on 30-40 (X apps > > etc.) you should delete all already installed... > >=20 > > I've got this problem when did pkg_add -r mod_musicindex and for some > > reason mod_musicindex didn't build the flac and libogg when > > $> make package-recursive > > specified. > > When the pkg_add get to these packages and they were not found on the > > web server, I've had to delete all installed packages by hand... uhh... > >=20 > > so, what would you say about that? >=20 > I'd say it's a great idea (and an ideal idea), but it's not easily > implementable. Where would pkg_add get its list of dependencies from? > The port Makefile? And what if the user doesn't have ports installed? >=20 > This is one of the many quirks of the ports vs. package system. Well, pkg_add *already* gets the list of dependencies from the .tbz file that it is either passed on the command line or it downloads. I believe that Anton is asking for a bit more separation between the "fetch all packages to be installed" and the "install all fetched (fought?) packages" phases of pkg_add's operation. However, given the way that pkg_add operates by invoking itself recursively, it might not be easy to do this without a major rewrite and algorithm change. G'luck, Peter --=20 Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 No language can express every thought unambiguously, least of all this one. --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkiyrPIACgkQ7Ri2jRYZRVMniACeNbYBCw8vAwlaycvU8f5K5k0X PPUAoINU2COfq5iJ4uOuGwJn0hdOEBo+ =+ofA -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--