From owner-dev-commits-ports-all@freebsd.org Fri Aug 20 09:08:28 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 928F165C4EF for ; Fri, 20 Aug 2021 09:08:28 +0000 (UTC) (envelope-from decke@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GrbQh3T6Mz55Fm for ; Fri, 20 Aug 2021 09:08:28 +0000 (UTC) (envelope-from decke@freebsd.org) Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: decke) by smtp.freebsd.org (Postfix) with ESMTPSA id 53B4373D1 for ; Fri, 20 Aug 2021 09:08:28 +0000 (UTC) (envelope-from decke@freebsd.org) Received: by mail-il1-f181.google.com with SMTP id s16so8807654ilo.9 for ; Fri, 20 Aug 2021 02:08:28 -0700 (PDT) X-Gm-Message-State: AOAM532Du4lhmmkFccWkpMgiRIkoRDeITkvnevMrjRcO98n7q2SU+hZ6 pkhVwe7XYmPhdrFwe2kMtZJmlobPUEkIBlbrH+GRjw== X-Google-Smtp-Source: ABdhPJwFYU0MElPOt+ZgBHmbqqu//dJIyQcuZF8EY9MkrrsqpWvrp5pMIYJabje9dzWIKLt7xcL3H1qBbc4/ABywfIw= X-Received: by 2002:a92:a008:: with SMTP id e8mr12805007ili.187.1629450507641; Fri, 20 Aug 2021 02:08:27 -0700 (PDT) MIME-Version: 1.0 References: <202108200809.17K89QLe089791@gitrepo.freebsd.org> <2444832.0dHE6SNnxz@beastie.bionicmutton.org> In-Reply-To: <2444832.0dHE6SNnxz@beastie.bionicmutton.org> From: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= Date: Fri, 20 Aug 2021 11:08:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 61fbacb8e363 - main - sysutils/plasma5-kinfocenter: Remove invalid CPE information To: Adriaan de Groot Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Aug 2021 09:08:28 -0000 On Fri, Aug 20, 2021 at 10:44 AM Adriaan de Groot wrote: > > Hi Bernhard, > > I see a mix of "Fix" and "Remove" commits around CPE information. > > On Friday, 20 August 2021 10:09:26 CEST Bernhard Froehlich wrote: > > > > sysutils/plasma5-kinfocenter: Remove invalid CPE information > > > -USES= cmake compiler:c++11-lib cpe gettext gl kde:5 pkgconfig > \ > > +USES= cmake compiler:c++11-lib gettext gl kde:5 pkgconfig \ > > > > What drives your choice to remove, here, rather than fix? I've seen you also > do > > +CPE_VENDOR= kde > > which, IMO, would have been a better change. (I don't pretend to know what the > CPE information is for or about, though) Hi Adrian, i've started working on correcting CPE information all over the portstree like you have already seen. Since this is a lot of work i've started to automate the validation process and also try to find "possible matches" for ports that don't have CPE entries yet. I've called it chkcpe and it's updated automatically via GitHub Actions once a day with the latest CPE data and the latest Portstree. Help is always welcome! https://github.com/decke/chkcpe Okay now in this particular case, the port plasma5-kinfocenter did contain USES=cpe but neither CPE_VENDOR nor CPE_PRODUCT and that combination could not be found in the CPE Dictionary - so it was listed on the "invalid" page: https://github.com/decke/chkcpe/wiki/invalid This list is what I am currently working on but fixing is a manual process where I try to identify what is actually wrong. If I can find a matching product I try to fix the entries but in some cases I cannot then I remove USES=cpe like in this case. -- Bernhard Froehlich http://www.bluelife.at/