From owner-cvs-src@FreeBSD.ORG  Tue Feb 26 12:33:32 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E2421065682;
	Tue, 26 Feb 2008 12:33:32 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 6F93A13C459;
	Tue, 26 Feb 2008 12:33:32 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 0046F46B67;
	Tue, 26 Feb 2008 07:33:31 -0500 (EST)
Date: Tue, 26 Feb 2008 12:33:31 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
In-Reply-To: <86d4qli8a1.fsf@ds4.des.no>
Message-ID: <20080226123107.N90776@fledge.watson.org>
References: <200802250855.m1P8t3w6052042@repoman.freebsd.org>
	<47C29A07.2070908@FreeBSD.org> <86d4qli8a1.fsf@ds4.des.no>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED;
	BOUNDARY="621616949-1302705894-1204029211=:90776"
Cc: cvs-src@FreeBSD.org, Kris Kennaway <kris@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	"David E. O'Brien" <obrien@FreeBSD.org>
Subject: Re: cvs commit: src/sys/fs/nullfs null_vfsops.c src/sys/fs/nwfs 
 nwfs_vfsops.c src/sys/fs/smbfs smbfs_vfsops.c src/sys/ufs/ufs     quota.h
 ufs_quota.c ufs_vfsops.c src/sys/kern vfs_default.c         vfs_vnops.c
 vnode_if.src src/sys/sys mount.h vnode.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Feb 2008 12:33:32 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--621616949-1302705894-1204029211=:90776
Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 25 Feb 2008, Dag-Erling Sm=F8rgrav wrote:

> No, it changes neither the API nor the ABI.  It replaces caddr_t (which i=
s=20
> typedef'd to char *) with void *, and those two are compatible types.

I'm sorry, but I disagree.  The case you failed to test involves a function=
=20
pointer typedef.  Here's the test I had to add to Arla to detect the change=
=20
with autoconf; without this autoconf mess and changed prototypes in the Arl=
a=20
nnpfs code, I can't build nnpfs on -CURRENT, and presumably now also on our=
=20
-STABLE branches:

AC_DEFUN([AC_BSD_FUNC_VFS_QUOTACTL], [
AC_CACHE_CHECK(if VFS_QUOTACTL takes caddr_t argument,=20
ac_cv_func_vfs_quotactl_caddr,
AC_TRY_COMPILE_KERNEL([
#ifdef HAVE_SYS_CDEFS_H
#include <sys/cdefs.h>
#endif
#include <sys/param.h>
#include <sys/types.h>
#include <sys/time.h>
#include <sys/uio.h>
#include <sys/vnode.h>
#include <sys/mount.h>

vfs_quotactl_t foo_quotactl;

int
foo_quotactl(struct mount *mp, int cmds, uid_t uid, caddr_t arg,
     struct thread *td)
{

         return (0);
}
],[],
ac_cv_func_vfs_quotctl_caddr=3Dyes,
ac_cv_func_vfs_quotactl_caddr=3Dno))
if test "$ac_cv_func_vfs_quotactl_caddr" =3D yes; then
         AC_DEFINE(HAVE_VFS_QUOTACTL_CADDR, 1,
         [define if VFS_QUOTACTL takes a caddr_t argument])
fi
])

--621616949-1302705894-1204029211=:90776--