From owner-cvs-all@FreeBSD.ORG Mon Jun 14 03:28:44 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4543616A4CE; Mon, 14 Jun 2004 03:28:44 +0000 (GMT) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7D7643D2D; Mon, 14 Jun 2004 03:28:43 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) i5E3SefQ083615; Mon, 14 Jun 2004 05:28:40 +0200 (CEST) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.10/8.12.10/Submit) id i5E3SZbQ083614; Mon, 14 Jun 2004 05:28:35 +0200 (CEST) (envelope-from marius) Date: Mon, 14 Jun 2004 05:28:35 +0200 From: Marius Strobl To: Brian Feldman Message-ID: <20040614052835.I1600@newtrinity.zeist.de> References: <200406131501.i5DF1Sqm065546@repoman.freebsd.org> <20040614021442.GB39574@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20040614021442.GB39574@green.homeunix.org>; from green@freebsd.org on Sun, Jun 13, 2004 at 10:14:42PM -0400 X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.25.0.62; VDF 6.25.0.92 (host: newtrinity.zeist.de) cc: cvs-ports@freebsd.org cc: Alexander Leidinger cc: cvs-all@freebsd.org cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/sysutils/cdrdao Makefile distinfo ports/sysutils/cdrdao/files patch-Makefile.in patch-configure patch-dao::ScsiIf-lib.cc patch-dao::cdrdao.drivers patch-dao::dao.cc patch-paranoia::isort.c patch-trackdb::Track.cc patch-trackdb::lec.cc ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2004 03:28:44 -0000 On Sun, Jun 13, 2004 at 10:14:42PM -0400, Brian Feldman wrote: > On Sun, Jun 13, 2004 at 03:01:28PM +0000, Alexander Leidinger wrote: > > - Disable the use of mlockall(2) on FreeBSD 5, even after the last round > > of fixes there are still issues. > > What are you referring to? The issues that are still there should not > affect simple mlockall(2) usage. > - On i386, depending on the program, mlockall() always returns EAGAIN. E.g. ntpd of the net/ntp port exhibits this problem. This isn't an issue with cdrdao. - On sparc64, every call of mlockall(MCL_CURRENT) returns EAGAIN, even in a program just doing that. Don't know about the other architectures. So there is no technical reason to not to use mlockall() as it no longer seems to have side effects (at least not on i386 and sparc64) like random processes crashing when another one uses it or causing panics like it did in the beginning. But I don't want to frighten the users of a port with the warnings that the failing mlockall() causes, especially if it is a verbose one like that of cdrecord.