Date: Sat, 28 May 2016 22:02:55 +0200 From: Kurt Jaeger <pi@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Kurt Jaeger <pi@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416053 - head/Mk/Uses Message-ID: <20160528200254.GI1036@fc.opsec.eu> In-Reply-To: <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc> References: <201605281719.u4SHJiAa008852@repo.freebsd.org> <6084DC9FC0E493931C0C3D6B@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi!
> | .if !target(do-configure) && ! ${qmake_ARGS:M_env}
> | -_USES_configure+= 450:qmake-configure
> | +do-configure: qmake-configure
> | + @${DO_NADA}
> | .endif
>
> I should explain a bit more.
>
> This goes against the Right Way Of Doing Things(c)(r)(tm).
>
> To add a target to be run in the targets pipeline, you use _USES_xxx, you
> never, ever, piggyback on an existing target, especially if you're not
> using it.
>
> So, please, back this out.
Done. I'm not sure *why* the kde folks requested this change
in the first place, so I'll ask them.
--
pi@FreeBSD.org +49 171 3101372 4 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160528200254.GI1036>