Date: Wed, 1 Jan 2020 10:05:27 -0700 From: Adam Weinberger <adamw@adamw.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r521738 - head/devel/rubygem-rspec Message-ID: <CAP7rwcgJED8sBWWJSPmDW__vsiDZ9y3eKCuNO7JGLgKb1DXQhw@mail.gmail.com> In-Reply-To: <202001011631.001GVQTM023723@repo.freebsd.org> References: <202001011631.001GVQTM023723@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 1, 2020 at 9:31 AM Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> wrote: > > Author: sunpoet > Date: Wed Jan 1 16:31:26 2020 > New Revision: 521738 > URL: https://svnweb.freebsd.org/changeset/ports/521738 > > Log: > Update version requirement of RUN_DEPENDS > > - Take maintainership I have to ask: Why are you taking maintainership of all these community-maintained modules? You're already the main person on ruby@, so grabbing maintainership when you update a port simply deprives others of the ability to contribute to them. Like, for example, that this rspec commit missed the fact that 3 of the updates were already stale. I would have done the bumps myself, but cannot do so now. (Don't get me wrong; I know you always catch them and the updates are coming in the next few days.) But I urge you to slow down on maintainership-grabbing from community-maintained modules, unless there's some reason that nobody else should be altering them. # Adam > > Modified: > head/devel/rubygem-rspec/Makefile > > Modified: head/devel/rubygem-rspec/Makefile > ============================================================================== > --- head/devel/rubygem-rspec/Makefile Wed Jan 1 16:31:20 2020 (r521737) > +++ head/devel/rubygem-rspec/Makefile Wed Jan 1 16:31:26 2020 (r521738) > @@ -6,18 +6,19 @@ PORTVERSION= 3.9.0 > CATEGORIES= devel rubygems > MASTER_SITES= RG > > -MAINTAINER= ruby@FreeBSD.org > +MAINTAINER= sunpoet@FreeBSD.org > COMMENT= Behaviour Driven Development in Ruby > > LICENSE= MIT > LICENSE_FILE= ${WRKSRC}/LICENSE.md > > -RUN_DEPENDS= rubygem-rspec-core>=${PORTVERSION:R}.0:devel/rubygem-rspec-core \ > - rubygem-rspec-expectations>=${PORTVERSION:R}.0:devel/rubygem-rspec-expectations \ > - rubygem-rspec-mocks>=${PORTVERSION:R}.0:devel/rubygem-rspec-mocks > +RUN_DEPENDS= rubygem-rspec-core>=${PORTVERSION:R}.0<3.10:devel/rubygem-rspec-core \ > + rubygem-rspec-expectations>=${PORTVERSION:R}.0<3.10:devel/rubygem-rspec-expectations \ > + rubygem-rspec-mocks>=${PORTVERSION:R}.0<3.10:devel/rubygem-rspec-mocks > > -NO_ARCH= yes > -USE_RUBY= yes > USES= gem > +USE_RUBY= yes > + > +NO_ARCH= yes > > .include <bsd.port.mk> -- Adam Weinberger adamw@adamw.org https://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcgJED8sBWWJSPmDW__vsiDZ9y3eKCuNO7JGLgKb1DXQhw>