From owner-svn-src-all@freebsd.org Sat Apr 20 15:15:37 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35023159009B for ; Sat, 20 Apr 2019 15:15:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BCCA994579 for ; Sat, 20 Apr 2019 15:15:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x844.google.com with SMTP id w26so1360793qto.13 for ; Sat, 20 Apr 2019 08:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HP5QqCrxgO/rEElo0iDGfWOcNg1kojxwJrv/Z2BRzvg=; b=GxsH4NFQrPzmt/3Np2V7xnRV5ofhpIqjiVLOyEZxoHKH7zFk1Cn3VU6Tf18sFgJG2s A2K+6ZzJpTMwbYO5sNhAJm8JZK/p+TP7/J6P1ZbZwA1JjD9SfwwFs9DLN0AjvyDw/OkR 1WlR/1fE+rWUlS1jY6cXYm1oO18j+YuKfVGJz64eqYoy13v8sz4D2jPT2TzXOSqkK6Ar 6oQYzLTO0lmmW2N3AR6O1mP1QPP19AnqZPbHdbe1kUOE79aKDQmEx5uUgRAIxS6M/cgz ZcsHI8g178PBV5mpohD5xENfO5mtLrroHFaenT92T17l45jVTs1GwZsy8RcCeat+M443 Nfjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HP5QqCrxgO/rEElo0iDGfWOcNg1kojxwJrv/Z2BRzvg=; b=KERIwlnUBOGMO3vXaGDhuep3+DToFhHDbq5I5GvUm9fulBPJ1yTtsQfzSP5jD3dTbo k5xiqN4yHnMEzuEBbR9HH0y3YvxarltIAWrvLKQeRdmZxeNyNInw/Q3PA8X0ATuaPFQ+ AWTaXW8dKqxGBom1yOGaWjkKbJBRGQi5y/GywSNSYGjKn1En2adEaGWPH3t8xubJK5B9 hI6jy6IpKpcr3w64oJhbJOEddTkwfVGdgszLVyWuu/HFnQuDtij7egt80Yu4tIWvR0VE 7eEalOPpFeROG78rYLHWXkR1lT//fql3zJNYPmVS7sBCfW1W9svyurNx9L87dbWUinRC U2lA== X-Gm-Message-State: APjAAAUtwDRIdKDHRQiIKCD2FJ5hILjVolQqLa/tnlJX5yTi8BvuJKjk gqSVDcr4wJCJSjHGjsmixkwd2/hbxXRZDGpw2II7dA== X-Google-Smtp-Source: APXvYqxeFpYHxxzNBSMlemNLAo/yjYvyqZM0YeHvXAqEY46ehWqMeD2bJ2aFf+vmNT/+56oJXW1CRILhs7JeZEXh7/c= X-Received: by 2002:ac8:4685:: with SMTP id g5mr7979301qto.242.1555773335777; Sat, 20 Apr 2019 08:15:35 -0700 (PDT) MIME-Version: 1.0 References: <201904201251.x3KCp6it044898@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 20 Apr 2019 09:15:23 -0600 Message-ID: Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf To: Alan Somers Cc: Justin Hibbits , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: BCCA994579 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.960,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 15:15:37 -0000 On Sat, Apr 20, 2019, 7:47 AM Alan Somers wrote: > On Sat, Apr 20, 2019 at 7:23 AM Justin Hibbits > wrote: > > > > > > > > On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: > >> > >> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits > wrote: > >> > > >> > > >> > > >> > On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > >> >> > >> >> Author: asomers > >> >> Date: Sat Apr 20 12:51:05 2019 > >> >> New Revision: 346441 > >> >> URL: https://svnweb.freebsd.org/changeset/base/346441 > >> >> > >> >> Log: > >> >> Use symlinks for kernel modules rather than hardlinks > >> >> > >> >> When aliasing a kernel module to a different name (ie if_igb for > if_em), > >> >> it's better to use symlinks than hard links. kldxref will omit > entries for > >> >> the links, ensuring that the loaded module has the correct name. > >> >> > >> >> > >> > > >> > > >> > Thanks! This should fix installkernel on my POWER9. > >> > > >> > - Justin > >> > >> What's the problem with your POWER9? Is that one of those msdosfs > >> /boot systems? If so, I don't think this will fix it. msdosfs > >> doesn't support either symlinks or hardlinks. Or is there some other > >> problem? > >> -Alan > > > > > > Yes it is. Well that's a bummer then. I thought we faked symlinks on > msdosfs, but on second thought not sure how well would do that. > > > > - Justin > > We should probably just remove the offending links on ppc, then. The > only harm is that after upgrading, ppc users would have to replace > fuse_load="YES" with fusefs_load="YES". > We should only do the Intel links on those platforms that have legacy users that need the old names. We should also only support the old names for one release or so. Warner >