From nobody Wed Apr 13 01:15:02 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2822E11D21D1 for ; Wed, 13 Apr 2022 01:15:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdPlq2smLz4cHr for ; Wed, 13 Apr 2022 01:15:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa2b.google.com with SMTP id b81so196514vkf.1 for ; Tue, 12 Apr 2022 18:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=alWFlHDuk7we4eNRYHDm3W/6aemn3mpQRruLwRPz6DQ=; b=ULFZ5Cw0NkUt2bINYzbtlqGI2/5Sx/J3EYAt7nMLNEDvlKuFFdoW873EbamXvooF1s HokBqyOis9s3ymYUXXPpSUXPcd/S5vpJ0uKUstuJdC2BG77nfejQlSR+TswbRE6uMPGC 4UaqRpXdbiMFz9xS+5AiluDChmcSaAiDYnHGPz+V3fAEykJjFY0KdJJNAfl31vgYeXwd MQEpF10ABqJomYNOBy5QD24vjaui7lPp/whPDEUDpKMD87FPWfvwzfCf+cp+sNw+hOMS rkkHbgsSNpe+Se6g7VDnwTSkqnXAiCbGwm5YAahhXTzKM6oSZbM/JLWGhcFb2b+qNCGf 6pMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=alWFlHDuk7we4eNRYHDm3W/6aemn3mpQRruLwRPz6DQ=; b=qaNkDTxJiq6k+JCPPB8VsPzARMMOsKzSn/R/h7FB5jTU4a3NXw79qfRpC1byywxcyG 9h9fCjVCNXq3YGk5zPcEgk2U66L0RcJ5mDySTBYwtKs0H/dWQTnvXGvgtWnfl3qY0pFh I/86Rh7eJ31548RldDYldBKzkU6r4IkdOM0jsY47/T2OvpstBulVWiAFYRZkW09xanEH pxrX4FpPOR+9RU6Tu/2h22HM4FgvBqZzqgxoLZNusV6U2MXpDcVIybu4LiiYDpyEU/Xc vGbhFa+1+1pVzP1PZvv0y5y8eOoRTk7/zw/GcVTos9PHjsfQbrefxPsE9GdBPr3Dp+zk OexA== X-Gm-Message-State: AOAM5336EIN08ZEydam2JFY3gUgdmIc4G29wZ0st7l/FzCZ3jF7a342D rKD03fxK0p7pjeSgXyph59AU0wCWpsVLFu7tsnjNCw== X-Google-Smtp-Source: ABdhPJwSPRieLeSJZ1Uzb7jsRHw0iRM2CB+S5ENucffhf96noaoIICyMTCT9v5j2eWAFyiw70mYuM5JooWaznju6gn0= X-Received: by 2002:a05:6122:219e:b0:345:c57d:4c55 with SMTP id j30-20020a056122219e00b00345c57d4c55mr3453723vkd.26.1649812512656; Tue, 12 Apr 2022 18:15:12 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> <12E7AA6A-F14E-4A34-9807-467A5D1CD251@panasas.com> In-Reply-To: <12E7AA6A-F14E-4A34-9807-467A5D1CD251@panasas.com> From: Warner Losh Date: Tue, 12 Apr 2022 19:15:02 -0600 Message-ID: Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around To: Ravi Pokala Cc: Kyle Evans , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c364fa05dc7ee887" X-Rspamd-Queue-Id: 4KdPlq2smLz4cHr X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=ULFZ5Cw0; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::a2b) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a2b:from]; MLMMJ_DEST(0.00)[dev-commits-src-main]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N --000000000000c364fa05dc7ee887 Content-Type: text/plain; charset="UTF-8" On Tue, Apr 12, 2022, 7:07 PM Ravi Pokala wrote: > -----Original Message----- > From: Kyle Evans > Date: 2022-04-12, Tuesday at 18:04 > To: Ravi Pokala > Cc: src-committers , "< > dev-commits-src-all@freebsd.org>" , < > dev-commits-src-main@freebsd.org> > Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing > around > > On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala > wrote: > > > > -----Original Message----- > > From: on behalf of Kyle Evans > > > Date: 2022-04-12, Tuesday at 17:34 > > To: , , > > > Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() > printing around > > > > The branch main has been updated by kevans: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0 > > > > commit 454630c72556d45e401f29f56b3317c2fb0499a0 > > Author: Kyle Evans > > AuthorDate: 2022-04-13 00:29:54 +0000 > > Commit: Kyle Evans > > CommitDate: 2022-04-13 00:30:30 +0000 > > > > stand: libefi: swap /Pci() printing around > > > > Printing device followed by interface matches, e.g., edk2. > Note that > > this is only a fallback, many firmware implementations will > provide the > > protocol that we'll use to format device paths. > > > > "(device,function)" makes more sense anyway, since that's the > logical organization (i.e. each unique device may have multiple functions). > > > > What was the rationale for doing "(function,device)" in the first > place? > > > > Based on tsoome's reaction when I pointed it out, the rationale was > "whoops" :-) > > That's a perfectly valid rationale! ;-) > Yea, this is a big table of stuff that's tedious to fill in. Since it isn't usually used, the mistake lay dormant. Woops indeed Warner -Ravi (rpokala@) > > > --000000000000c364fa05dc7ee887 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Apr 12, 2022, 7:07 PM Ravi Pokala <rpokala@freebsd.org> wrote:
-----Original Message-----
From: Kyle Evans <kevans@freebsd.org>
Date: 2022-04-12, Tuesday at 18:04
To: Ravi Pokala <rpokala@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, "&l= t;dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, <dev-commit= s-src-main@freebsd.org>
Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing arou= nd

=C2=A0 =C2=A0 On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala <rpokala@free= bsd.org> wrote:
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 > -----Original Message-----
=C2=A0 =C2=A0 > From: <owner-src-committers@freebsd.org= > on behalf of Kyle Evans <kevans@FreeBSD.org>
=C2=A0 =C2=A0 > Date: 2022-04-12, Tuesday at 17:34
=C2=A0 =C2=A0 > To: <src-committers@FreeBSD.org>, <dev-commits-= src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
=C2=A0 =C2=A0 > Subject: git: 454630c72556 - main - stand: libefi: swap = /Pci() printing around
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0The branch main has been updated by k= evans:
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0URL: https://cgit.FreeBSD.org/src/commit/?id= =3D454630c72556d45e401f29f56b3317c2fb0499a0
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0commit 454630c72556d45e401f29f56b3317= c2fb0499a0
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Author:=C2=A0 =C2=A0 =C2=A0Kyle Evans= <kevans@FreeBSD.org>
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0AuthorDate: 2022-04-13 00:29:54 +0000=
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Commit:=C2=A0 =C2=A0 =C2=A0Kyle Evans= <kevans@FreeBSD.org>
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0CommitDate: 2022-04-13 00:30:30 +0000=
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0stand: libefi: swap /Pc= i() printing around
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Printing device followe= d by interface matches, e.g., edk2.=C2=A0 Note that
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0this is only a fallback= , many firmware implementations will provide the
=C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0protocol that we'll= use to format device paths.
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 > "(device,function)" makes more sense anyway, s= ince that's the logical organization (i.e. each unique device may have = multiple functions).
=C2=A0 =C2=A0 >
=C2=A0 =C2=A0 > What was the rationale for doing "(function,device)= " in the first place?
=C2=A0 =C2=A0 >

=C2=A0 =C2=A0 Based on tsoome's reaction when I pointed it out, the rat= ionale was "whoops" :-)

That's a perfectly valid rationale! ;-)

Yea, this is a big table of stuf= f that's tedious to fill in. Since it isn't usually used, the mista= ke lay dormant. Woops indeed

Warner

-Ravi (rpokala@)


--000000000000c364fa05dc7ee887--