From owner-svn-ports-head@FreeBSD.ORG  Wed Oct 30 14:41:53 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id C60F172; Wed, 30 Oct 2013 14:41:53 +0000 (UTC)
Date: Wed, 30 Oct 2013 14:41:53 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Dmitry Marakasov <amdmi3@FreeBSD.org>
Subject: Re: svn commit: r332113 - head/textproc/uncrustify
Message-ID: <20131030144153.GC34668@FreeBSD.org>
References: <201310301412.r9UECUeK002034@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201310301412.r9UECUeK002034@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2013 14:41:53 -0000

On Wed, Oct 30, 2013 at 02:12:30PM +0000, Dmitry Marakasov wrote:
> New Revision: 332113
> URL: http://svnweb.freebsd.org/changeset/ports/332113
> 
> +OPTIONS_DEFINE=	DOCS
> +OPTIONS_DEFAULT=DOCS

This last line is redundant.

> -	${MKDIR} ${DOCSDIR}
> -	cd ${WRKSRC}/documentation && ${COPYTREE_SHARE} '*' ${DOCSDIR}
> -.endif
> +	cd ${WRKSRC}/documentation && ${COPYTREE_SHARE} '*' ${STAGEDIR}${DOCSDIR}/

Using dot (.) instead of '*' is preferred, see PH section 5.15.

./danfe