From owner-cvs-src@FreeBSD.ORG  Tue May 13 07:36:36 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id F3A3337B401; Tue, 13 May 2003 07:36:35 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 953C243F93; Tue, 13 May 2003 07:36:34 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.8/8.12.3) with ESMTP id h4DEaXkA025037;
	Tue, 13 May 2003 08:36:33 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Tue, 13 May 2003 08:35:46 -0600 (MDT)
Message-Id: <20030513.083546.133906327.imp@bsdimp.com>
To: des@ofug.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <xzphe7zmb45.fsf@flood.ping.uio.no>
References: <20030512.223927.39164038.imp@bsdimp.com>
	<xzpllxbmcqr.fsf@flood.ping.uio.no>
	<xzphe7zmb45.fsf@flood.ping.uio.no>
X-Mailer: Mew version 2.1 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: joe@FreeBSD.org
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: obrien@FreeBSD.org
Subject: 
 Re: cvs commit: src/share/man/man4 umass.4 src/sys/dev/usb umass.c
 usbdevs
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 May 2003 14:36:36 -0000

In message: <xzphe7zmb45.fsf@flood.ping.uio.no>
            Dag-Erling Smorgrav <des@ofug.org> writes:
: Dag-Erling Smorgrav <des@ofug.org> writes:
: > "M. Warner Losh" <imp@bsdimp.com> writes:
: > > This patch doesn't address those drivers that might wish to build not
: > > in the usb.ko module, for example the urio driver and I'm sure others.
: > I know.  I did mention that it was incomplete, didn't I?
: 
: This one should be a little better.  The second patch fixes the
: #include lines.  It would be advantageous if the awk script could
: generate usbdevs.h and usbdevs_data.h separately, as the latter is
: only required by the usb driver and it's a waste of time and space to
: generate it for all the other drivers.

The makefiles for the modules still need to be included.  I think I
like my approach a little better, but it has the flaw of not
necessarily generating usbdevs_data.h if usbdevs.h isn't generated.
Since usbdevs_data.h is used only when USBVERBOSE is defined, I would
have thought that we'd not need it (since USBVERBOSE is supposed to be
an option), but it looks like it is always defined, so we get a lot of
extra junk in our usb.ko module, even on install media...

Warner