From nobody Sun Dec 11 23:37:55 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NVh5T3FTVz4klmN; Sun, 11 Dec 2022 23:38:05 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NVh5T0qbhz4Hys; Sun, 11 Dec 2022 23:38:05 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Authentication-Results: mx1.freebsd.org; none Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 9DD1B1C0EFE; Mon, 12 Dec 2022 00:37:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=anongoth.pl; s=ANONGOTH; t=1670801876; bh=qO17tpMYEoNzjvmA5et4aerumMg7H0f6USYUw733xT4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=eR2LDDa49J/8wOu6DznluoJifV1wEunDIBFiSMSP9WeyzEde9tzqmLRbsUWxFUOty uGPHIYcs1YQS80anLKF/QxmMUv9Gs9qISqTlbjb5uDyWbJkfMK70xKag254x3rKgjT ylhE5pze5KgE5Ar9mTIy43ng+q6iz6BHhzoRsNXAbZGahtfW+o89Dnr89xRHfg6THR UMQwGe2MVQqh2HJgEvm7wPRCf5ZnELOOttpTdfQr6JjgZ+LdAQaS62pkKSSRNhofhU GmlQslqPegTNpKqRRG5QOWyq7na+NtfKbYB9iNnf4i8gbHYmi7/isilRyNtOoRLgxw RmxEOxozkehAg== Date: Mon, 12 Dec 2022 00:37:55 +0100 From: Piotr Kubaj To: Yuri Victorovich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d5a8c7ca5954 - main - cad/nvc: Correction of the conditional statement Message-ID: References: <202212111922.2BBJMN98026340@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wSdMhO1JqLuM2wOO" Content-Disposition: inline In-Reply-To: <202212111922.2BBJMN98026340@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4NVh5T0qbhz4Hys X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --wSdMhO1JqLuM2wOO Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline So, now it ended up with: .include .if ${ARCH} == "i386" # see the bug#268319 for the LTO failure on i386 CONFIGURE_ARGS+= --disable-lto # workaround for https://github.com/nickg/nvc/issues/579 (undefined symbol: _GLOBAL_OFFSET_TABLE_, see error: undefined symbol: _GLOBAL_OFFSET_TABLE_) .endif ${OTHER_STUFF} .include .if ${ARCH} == powerpc64 CONFIGURE_ARGS+= --enable-lto=no .endif Why not use one conditional for both i386 and powerpc64? Does double inclusion of bsd.port.options.mk even work correctly? On 22-12-11 19:22:23, Yuri Victorovich wrote: >The branch main has been updated by yuri: > >URL: https://cgit.FreeBSD.org/ports/commit/?id=d5a8c7ca5954840b99c01aff42630441b90ae237 > >commit d5a8c7ca5954840b99c01aff42630441b90ae237 >Author: Yuri Victorovich >AuthorDate: 2022-12-11 19:21:56 +0000 >Commit: Yuri Victorovich >CommitDate: 2022-12-11 19:21:56 +0000 > > cad/nvc: Correction of the conditional statement >--- > cad/nvc/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/cad/nvc/Makefile b/cad/nvc/Makefile >index 4b8e9d10d601..9404d23dc65b 100644 >--- a/cad/nvc/Makefile >+++ b/cad/nvc/Makefile >@@ -34,6 +34,8 @@ GNU_CONFIGURE= yes > LDFLAGS+= -lexecinfo > > CONFIGURE_ARGS= --with-llvm=${LOCALBASE}/bin/llvm-config${LLVM_VERSION} >+ >+.include > .if ${ARCH} == "i386" # see the bug#268319 for the LTO failure on i386 > CONFIGURE_ARGS+= --disable-lto # workaround for https://github.com/nickg/nvc/issues/579 (undefined symbol: _GLOBAL_OFFSET_TABLE_, see error: undefined symbol: _GLOBAL_OFFSET_TABLE_) > .endif --wSdMhO1JqLuM2wOO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOWadMwFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydkIwP/AnaB+gxiNrUYr2g+DzUm78owqkBWi+UZUYomkXDo0m2wzXpWyXqkM7u M5v6FjN2qK6QtqWiXXQ5sVXKcf1ZvUKuYxT7rOKolIGKuQQGz4RwTP+LHuzcC/oh hY2OiJFnJkqQj3YqdY4+eWp/Hib7DDLli+e/Lwlj1UEnyc6E/6qRGJx8tLlXlsQj uvvGjPjvDfrg30UUu7EUpFzbPp5SB4KIPjLemqGeExL4O8pAo3PFZNWeK1fg/35M MZoGXmteMgp3fBy0AGrB54voDkKy6hhUPxqmMPOF3fueB0mX5OzEsZLSYp8ThTX3 7uU9gEv7dpjNfqKwXTjG6picee8+RR9ZAtEQf5y9s+PzTesfW1EPBbj7R45wIpp5 P+PXmFNVIv+Ew/iVrtJoIU6W3I09+p25k3fMb4jaktYV7i5+Jh6C40/Hujsm1/PP MXQFQEu129cBJ4/+s0ARR++SV98mpQTwJVtdNquXnZtwmZ+1TQiGVTxTDgIAIjLX fwEAucTKxrFIrtN88rZTWx1oJMJsl1/+sdH7U3vWsQmMS+rNwEKefMDfY+aqHt3Q T6GR7NITOI/RuSppuRcZ+MBljErw3kCB5YBr2BD2HY+ZR/jRCKVQ2wsVEa2Dr9EQ 3OY2Yyhh6Wt5PC3o0mg15VB3l/V0M5ac9afNBRwfTcY2lCRGgb+c =VTXv -----END PGP SIGNATURE----- --wSdMhO1JqLuM2wOO--