From owner-freebsd-bugs@freebsd.org Wed Jul 6 23:14:43 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D67BB758EA for ; Wed, 6 Jul 2016 23:14:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 648C311F7 for ; Wed, 6 Jul 2016 23:14:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u66NEheV058425 for ; Wed, 6 Jul 2016 23:14:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 210882] [PATCH] ipfw sched show output garbled after r270424 Date: Wed, 06 Jul 2016 23:14:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 23:14:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210882 Bug ID: 210882 Summary: [PATCH] ipfw sched show output garbled after r270424 Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Keywords: patch, regression Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: madpilot@FreeBSD.org CC: melifaro@FreeBSD.org Created attachment 172183 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D172183&action= =3Dedit ipfw-sched-show-patch I noticed the output of "ipfw sched show" became garbled in recent head, for example: 00001: 460.000 Kbit/s 0 ms burst 5120=20 sched 1 type QFQ flags 0x0 0 buckets 1 active Children flowsets: 16 15 14 13 12 11=20 BKT Prot ___Source IP/port____ ____Dest. IP/port____ Tot_pkt/bytes Pkt/Byte= Drp 0 ip 0.0.0.0/0 0.0.0.0/0 309679 166803112 0 = 0 181 00002: 7.424 Mbit/s 0 ms burst 10240=20 sched 2 type QFQ flags 0x0 0 buckets 1 active Children flowsets: 26 25 24 23 22 21=20 0 ip 0.0.0.0/0 0.0.0.0/0 309679 166803112 0 = 0 181 0 ip 0.0.0.0/0 0.0.0.0/0 411158 519899222 0= =20=20=20 0 0 00003: 350.000 Kbit/s 0 ms burst 5120=20 sched 3 type QFQ flags 0x0 0 buckets 1 active Children flowsets: 31=20 0 ip 0.0.0.0/0 0.0.0.0/0 309679 166803112 0 = 0 181 0 ip 0.0.0.0/0 0.0.0.0/0 411158 519899222 0= =20=20=20 0 0 0 ip 0.0.0.0/0 0.0.0.0/0 8465 12575050 34 50524 8 The script keeps appending things to the buffer after printing them. Attach= ed patch adds a buffer flush after printing it. BTW there is also a change in output due to the toPrint check just above my change. It used to print the header after each scheduler. I'm going to test= a patch for this issue too and attach it here if I get something working. CCing melifaro as he's the author of the commit which caused the regression. --=20 You are receiving this mail because: You are the assignee for the bug.=